Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing for fully implemented search components, fix bug in debounce #603

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

JackVCurtis
Copy link
Contributor

Summary

Ticket: 🤖 | Search | Search bar in nearby transit

What is this PR for?

The implementation of this ticket was merged in #584 to unblock other work, this wraps up the ticket with the necessary testing.

This PR
iOS

  • If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?
    • Add temporary machine translations, marked "Needs Review"
      android
  • All user-facing strings added to strings resource

Testing

What testing have you done?

Testing for everything but the SearchResult component, since at the moment that's just a placeholder

@JackVCurtis JackVCurtis marked this pull request as ready for review December 20, 2024 16:47
@JackVCurtis JackVCurtis requested a review from a team as a code owner December 20, 2024 16:47
@JackVCurtis JackVCurtis merged commit 68d199c into main Dec 23, 2024
5 checks passed
@JackVCurtis JackVCurtis deleted the jvc-android-search-in-nearby-tests branch December 23, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants