refactor(iOS): Move stop details fetching into VM #599
Xcode Cloud / MBTA Transit Staging | PR Branch Workflow | iosAppRetries - iOS
succeeded
Dec 19, 2024 in 27m 30s
50 warnings
| Report Summary | |
|---|---|
| Errors | 0 |
| Test Failures | 0 |
| Analysis Issues | 0 |
| Warnings | 50 |
Details
50 Warnings
Details
iosApp/iosApp/ViewModels/StopDetailsViewModel.swift:472
File Length Violation: File should contain 400 lines or less: currently contains 472 (file_length)
Line Length Violation: Line should be 120 characters or less; currently it has 123 characters (line_length)
Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 315 lines (type_body_length)
Initialization of immutable value 'springboard' was never used; consider replacing with assignment to '_' or removing it
Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)
Instance method 'wait' is unavailable from asynchronous contexts; Use await fulfillment(of:timeout:enforceOrder:) instead; this is an error in Swift 6
Line Length Violation: Line should be 120 characters or less; currently it has 124 characters (line_length)
Instance method 'wait' is unavailable from asynchronous contexts; Use await fulfillment(of:timeout:enforceOrder:) instead; this is an error in Swift 6
Redundant Optional Initialization Violation: Initializing an optional variable with nil is redundant (redundant_optional_initialization)
Immutable value 'error' was never used; consider replacing with '_' or removing it
Redundant Optional Initialization Violation: Initializing an optional variable with nil is redundant (redundant_optional_initialization)
File Length Violation: File should contain 400 lines or less: currently contains 564 (file_length)
Line Length Violation: Line should be 120 characters or less; currently it has 126 characters (line_length)
Initialization of immutable value 'mapVM' was never used; consider replacing with assignment to '_' or removing it
Expression implicitly coerced from 'URLResponse?' to 'Any'
Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 307 lines (type_body_length)
Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)
Redundant Optional Initialization Violation: Initializing an optional variable with nil is redundant (redundant_optional_initialization)
Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)
Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 344 lines (type_body_length)
Line Length Violation: Line should be 120 characters or less; currently it has 123 characters (line_length)
Immutable value 'error' was never used; consider replacing with '_' or removing it
Prefer For-Where Violation: `where` clauses are preferred over a single `if` inside a `for` (for_where)
Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Unused Optional Binding Violation: Prefer `!= nil` over `let _ =` (unused_optional_binding)
Line Length Violation: Line should be 120 characters or less; currently it has 139 characters (line_length)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Large Tuple Violation: Tuples should have at most 2 members (large_tuple)
Blanket Disable Command Violation: Use 'next', 'this' or 'previous' instead to disable the 'type_body_length' rule once, or re-enable it as soon as possible` (blanket_disable_command)
'MapContentGestureContext' is deprecated: renamed to 'InteractionContext'
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Line Length Violation: Line should be 120 characters or less; currently it has 150 characters (line_length)
Todo Violation: TODOs should be resolved (Add all possible alert effects...) (todo)
'MapContentGestureContext' is deprecated: renamed to 'InteractionContext'
Immutable value 'tripFilter' was never used; consider replacing with '_' or removing it
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Function Parameter Count Violation: Function should have 5 parameters or less: it currently has 6 (function_parameter_count)
Line Length Violation: Line should be 120 characters or less; currently it has 137 characters (line_length)
Line Length Violation: Line should be 120 characters or less; currently it has 139 characters (line_length)
Todo Violation: TODOs should be resolved (figure out something to do if ...) (todo)
Line Length Violation: Line should be 120 characters or less; currently it has 124 characters (line_length)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Line Length Violation: Line should be 120 characters or less; currently it has 137 characters (line_length)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Using '_' to ignore the result of a Void-returning function is redundant
Line Length Violation: Line should be 120 characters or less; currently it has 122 characters (line_length)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Annotations
Check notice on line 472 in iosApp/iosApp/ViewModels/StopDetailsViewModel.swift
xcode-cloud / MBTA Transit Staging | PR Branch Workflow | iosAppRetries - iOS
iosApp/iosApp/ViewModels/StopDetailsViewModel.swift#L472
File Length Violation: File should contain 400 lines or less: currently contains 472 (file_length)
Check notice on line 59 in iosApp/iosAppTests/ViewModels/StopDetailsViewModelTests.swift
xcode-cloud / MBTA Transit Staging | PR Branch Workflow | iosAppRetries - iOS
iosApp/iosAppTests/ViewModels/StopDetailsViewModelTests.swift#L59
Instance method 'wait' is unavailable from asynchronous contexts; Use await fulfillment(of:timeout:enforceOrder:) instead; this is an error in Swift 6
Check notice on line 7 in iosApp/iosApp/ContentView.swift
xcode-cloud / MBTA Transit Staging | PR Branch Workflow | iosAppRetries - iOS
iosApp/iosApp/ContentView.swift#L7
Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 344 lines (type_body_length)
Check notice on line 362 in iosApp/iosApp/ContentView.swift
xcode-cloud / MBTA Transit Staging | PR Branch Workflow | iosAppRetries - iOS
iosApp/iosApp/ContentView.swift#L362
Large Tuple Violation: Tuples should have at most 2 members (large_tuple)
Check notice on line 9 in iosApp/iosApp/ViewModels/StopDetailsViewModel.swift
xcode-cloud / MBTA Transit Staging | PR Branch Workflow | iosAppRetries - iOS
iosApp/iosApp/ViewModels/StopDetailsViewModel.swift#L9
Blanket Disable Command Violation: Use 'next', 'this' or 'previous' instead to disable the 'type_body_length' rule once, or re-enable it as soon as possible` (blanket_disable_command)
Check notice on line 25 in iosApp/iosAppTests/ViewModels/StopDetailsViewModelTests.swift
xcode-cloud / MBTA Transit Staging | PR Branch Workflow | iosAppRetries - iOS
iosApp/iosAppTests/ViewModels/StopDetailsViewModelTests.swift#L25
Using '_' to ignore the result of a Void-returning function is redundant
Loading