feat: set up Android prod deployments #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boringcactus
commented
Dec 17, 2024
| Pushing a new tag will automatically deploy to the internal testing group (on iOS), and then release notes can be added and the build can be more widely published manually. | ||
| Pushing a new tag with the `ios-` prefix will automatically deploy to the iOS internal testing group, and then release notes can be added and the build can be more widely published manually. |
There was a problem hiding this comment.
I have not yet moved the Xcode Cloud workflow to require this prefix on iOS; I think I'll do that as I merge this PR.
| versionName = (findProperty("android.injected.version.name") ?: "0.1.0") as String | ||
| versionName = "0.2.0" |
There was a problem hiding this comment.
This has been sitting at 0.1.0 since we started; this seems like as reasonable a time as any to bump it up a bit.
I'm not actually sure why this had been defined in Fastlane before.
JackVCurtis
reviewed
Dec 18, 2024
| @@ -0,0 +1,87 @@ | |||
| name: Android Prod Deploy | |||
There was a problem hiding this comment.
Did you use a template for this? Obviously if it's all you 👍 but if there's reference documentation it would be nice to see a quick comment!
There was a problem hiding this comment.
Mostly I just copied the Android build and upload parts of the existing CI workflow.
JackVCurtis
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: 🤖 | Prod release workflow
It's really this easy.
iOS
android
Testing
Verified that this uploads a build to the prod Google Play listing.