-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: set up CI with Android builds #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
question: Several of the files in the fastlane directory are empty. Are there reasons for including those?
android/fastlane/README.md
Outdated
@@ -0,0 +1,40 @@ | |||
fastlane documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Do you think that devs will ever have to run this themselves (in which case it might be worth linking to this from the main Readme), or will it likely just be for CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the only context in which someone's likely to run this locally is if it has stopped working and they're debugging it. Fastlane generates this README automatically when run locally, and I figured I'd leave it in.
Fastlane uses those metadata files as the source of truth for the Google Play listing, so if we include the empty files now we'll know what names they should have when we start filling in the store page. |
Summary
Ticket: Port relevant code from experiment into mobile_app repo › CI
Ports in the Android CI process from the previous repo.
Testing
Checked the Fastlane process locally.