Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: set up CI with Android builds #5

Merged
merged 7 commits into from
Nov 27, 2023
Merged

ci: set up CI with Android builds #5

merged 7 commits into from
Nov 27, 2023

Conversation

boringcactus
Copy link
Member

Summary

Ticket: Port relevant code from experiment into mobile_app repo › CI

Ports in the Android CI process from the previous repo.

Testing

Checked the Fastlane process locally.

@boringcactus boringcactus marked this pull request as ready for review November 21, 2023 18:27
@boringcactus boringcactus requested a review from a team as a code owner November 21, 2023 18:27
Copy link

@arkadyan arkadyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

question: Several of the files in the fastlane directory are empty. Are there reasons for including those?

@@ -0,0 +1,40 @@
fastlane documentation

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Do you think that devs will ever have to run this themselves (in which case it might be worth linking to this from the main Readme), or will it likely just be for CI?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only context in which someone's likely to run this locally is if it has stopped working and they're debugging it. Fastlane generates this README automatically when run locally, and I figured I'd leave it in.

@boringcactus
Copy link
Member Author

Fastlane uses those metadata files as the source of truth for the Google Play listing, so if we include the empty files now we'll know what names they should have when we start filling in the store page.

@boringcactus boringcactus merged commit 8e45501 into main Nov 27, 2023
1 check passed
@boringcactus boringcactus deleted the mth-ci branch November 27, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants