ci: formatting, unit tests #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaylaBrady
commented
Dec 19, 2023
| kotlinGradle { ktfmt().kotlinlangStyle() } | ||
| } | ||
|
|
||
| tasks.withType<org.gradle.api.tasks.testing.Test> { |
There was a problem hiding this comment.
taken from this SO post about logging test output. There is a plugin linked from a different answer that does this and more, though customizing test logging seems to me like something that should be reasonably done out of the box.
Also planning to add a ticket to the backlog for reporting code coverage on the PR, potentially with JaCoCo
KaylaBrady
commented
Dec 19, 2023
| path: ~/.konan | ||
| key: konan-${{ runner.os }}-${{ hashFiles('build.gradle.kts') }} | ||
| restore-keys: konan-${{ runner.os }} | ||
| - run: ./gradlew spotlessCheck |
There was a problem hiding this comment.
moved spotless check up above running tests
boringcactus
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: mobile_app linting & unit test CI
What is this PR for?
This adds linting & android unit tests as part of CI. Largely copied from maple-kotlin-multiplatform with a few exceptions noted in comments.
This also adds pre-commit hooks and runs them across all files, resulting in some minor formatting changes of unrelated files.
Testing
What testing have you done?
Confirmed running as expected for this PR