fix: Load correct nearby location on launch #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the app was started with location permissions already granted, nearby transit was instead loading the default camera location, rather that the phone's current GPS location. The NearbyTransitLocationProvider was implemented in a silly way where it was effectively static, and on app startup, `currentLocation` and `viewportProvider.viewport` were both changing and running their `onChange` at the same time, so the current location was getting overridden by the default camera state.
boringcactus
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: Fix: Nearby transit stuck on Park St after opening app
When the app was started with location permissions already granted, nearby transit was instead loading the default camera location, rather that the phone's current GPS location. The NearbyTransitLocationProvider was implemented in a silly way where it was effectively immutable, and on app startup,
currentLocationandviewportProvider.viewportwere both changing and running theironChangeat the same time, so the current location was getting overridden by the default camera state.Testing
Updated tests to handle the changes