feat(HomeMapView): Draw alerting segments as dashed lines #123
Conversation
KaylaBrady
force-pushed
the
kb-draw-alerting-segments
branch
from
24a8262 to
61ac3f0
Compare
|
Update: GL alerting segment showing! Restarting my locally running backend got it to appear, so I suspect there is something going on in the backend that is preventing new alerts from being pushed - I'll make a ticket to investigate that more. There is also still an issue here since I would expect Gov't center to haymarket to show as alerting - will look into that further. |
There was a problem hiding this comment.
This looks great! Nice work. Having overlapping routes only display starting at the station they split at looks so much better. Now commuter rail needs a similar treatment, but it looks like it'll be pretty straightforward to add cross-route handling, could that be at all related to the green line follow up issues?
Edit: Oops, didn't refresh before posting that, sounds unrelated.
| static func createRouteLayer(route: Route) -> LineLayer { | ||
| var routeLayer = LineLayer( | ||
| id: Self.getRouteLayerId(route.id), | ||
| static func createRouteLayer(route: Route) -> [LineLayer] { |
There was a problem hiding this comment.
I feel weird about leaving the function name singular when it's returning multiple, but there's already a plural. And something like createRouteLayerPair or createRouteLayerSet are still subject to change and too close to type names... Maybe instead createRouteLayers could be createAllRouteLayers and this createRouteLayers?
KaylaBrady
force-pushed
the
kb-draw-alerting-segments
branch
from
e75c60c to
f0c9335
Compare
Summary
Ticket: Style alerting segments on the map
What is this PR for?
Draw alerting segments on map as dashed lines.
Testing
What testing have you done?
Updated / added unit tests and ran locally.
Still something funky going on that is preventing a GL alert from showing up as expected, but OL & RL are working. Hoping for this incremental step to be reviewed first and will dive into the GL alert as a follow-up.