feat(RouteSegment): Break into alerting / non-alerting segments #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaylaBrady
commented
Apr 8, 2024
| @@ -3,22 +3,140 @@ package com.mbta.tid.mbta_app.model | |||
| import kotlinx.serialization.SerialName | |||
| import kotlinx.serialization.Serializable | |||
|
|
|||
| interface IRouteSegment { | |||
There was a problem hiding this comment.
Adding as an interface since Kotlin doesn't allow extending data classes
KaylaBrady
force-pushed
the
kb-alerting-segments
branch
from
24a8262 to
d65dc17
Compare
BrandonTR
approved these changes
Apr 10, 2024
| .toSet() | ||
| routes = routes.plus(sourceRouteId) | ||
|
|
||
| var hasServiceAlert: Boolean = |
There was a problem hiding this comment.
We could make this a val instead of a var
| routes = routes.plus(sourceRouteId) | ||
|
|
||
| var hasServiceAlert: Boolean = | ||
| alertsByStop[stopId]!!.serviceAlerts.any { alert -> |
There was a problem hiding this comment.
I typically prefer avoiding the double bang operator if we can. It seems like it would be clean enough to just do:
val hasServiceAlert: Boolean? =
alertsByStop[stopId]?.serviceAlerts?.any { alert ->
alert.anyInformedEntity { informedEntity ->
informedEntity.route != null &&
routes.contains(informedEntity.route)
}
}
hasServiceAlert == true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: Break route shape segments into alerting / non-alerting segments
What is this PR for?
This adds functionality to break a route segment into a list of alerting / non-alerting segments given the state of alerts.
This will be used for formatting alerting segments differently on the map with an approach similar to how StopSourceGenerator used a map of alertsByStop
Testing
What testing have you done?
Added unit tests