-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ios): Display canonical route patterns on map (using new segmented route shapes) #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for further breaking down these route segments into alerting/non-alerting segments
KaylaBrady
changed the title
Kb use route segments
feat(ios): Display canonical route patterns on map (using new segmented route shapes)
Apr 5, 2024
boringcactus
reviewed
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be worth cleaning up some of these SwiftLint warnings.
@@ -6,6 +6,7 @@ | |||
// Copyright © 2024 MBTA. All rights reserved. | |||
// | |||
|
|||
import OSLog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this import used here?
boringcactus
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: Display canonical route patterns on homepage map
What is this PR for?
Use segmented route shapes to draw lines on the map (endpoint added in mbta/mobile_app_backend#112). This results in drawing the most canonical shapes for each line in a single direction, and will also support styling alerting segments differently in the future.
Testing
What testing have you done?
Updated existing tests, inspected shapes locally.
Worcester line now showing