Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): Display canonical route patterns on map (using new segmented route shapes) #115

Merged
merged 10 commits into from
Apr 8, 2024

Conversation

KaylaBrady
Copy link
Collaborator

@KaylaBrady KaylaBrady commented Apr 5, 2024

Summary

Ticket: Display canonical route patterns on homepage map

What is this PR for?

Use segmented route shapes to draw lines on the map (endpoint added in mbta/mobile_app_backend#112). This results in drawing the most canonical shapes for each line in a single direction, and will also support styling alerting segments differently in the future.

Testing

What testing have you done?

Updated existing tests, inspected shapes locally.
Worcester line now showing
IMG_0039
IMG_0043

In preparation for further breaking down these route segments into alerting/non-alerting segments
@KaylaBrady KaylaBrady requested a review from a team as a code owner April 5, 2024 17:26
@KaylaBrady KaylaBrady requested a review from boringcactus April 5, 2024 17:26
@KaylaBrady KaylaBrady changed the title Kb use route segments feat(ios): Display canonical route patterns on map (using new segmented route shapes) Apr 5, 2024
@KaylaBrady KaylaBrady marked this pull request as draft April 5, 2024 17:29
@KaylaBrady KaylaBrady marked this pull request as ready for review April 5, 2024 17:53
Copy link
Member

@boringcactus boringcactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be worth cleaning up some of these SwiftLint warnings.

@@ -6,6 +6,7 @@
// Copyright © 2024 MBTA. All rights reserved.
//

import OSLog
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this import used here?

@KaylaBrady KaylaBrady merged commit db9c6b2 into main Apr 8, 2024
5 checks passed
@KaylaBrady KaylaBrady deleted the kb-use-route-segments branch April 8, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants