feat: Add alert icons for stops on the map #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # iosApp/iosApp/ContentView.swift
EmmaSimon
commented
Apr 3, 2024
| @@ -44,13 +44,29 @@ class StopLayerGenerator { | |||
| static func getStopLayerIcon(_ locationType: LocationType) -> Value<ResolvedImage> { | |||
| switch locationType { | |||
There was a problem hiding this comment.
I tried to move back to a single stop layer like I mentioned in this thread, but it doesn't allow you to use .zoom outside of a top level .step expression for some reason, so having it nested one layer deeper in a .match doesn't seem possible.
KaylaBrady
reviewed
Apr 3, 2024
shared/src/commonMain/kotlin/com/mbta/tid/mbta_app/model/Stop.kt
Outdated
Show resolved
Hide resolved
shared/src/commonMain/kotlin/com/mbta/tid/mbta_app/model/AlertAssociatedStop.kt
Show resolved
Hide resolved
shared/src/commonMain/kotlin/com/mbta/tid/mbta_app/model/GlobalStaticData.kt
Show resolved
Hide resolved
shared/src/commonMain/kotlin/com/mbta/tid/mbta_app/model/AlertAssociatedStop.kt
Outdated
Show resolved
Hide resolved
shared/src/commonTest/kotlin/com/mbta/tid/mbta_app/model/GlobalResponseTest.kt
Outdated
Show resolved
Hide resolved
KaylaBrady
approved these changes
Apr 4, 2024
| return alerts.filter { Alert.serviceDisruptionEffects.contains(it.effect) } | ||
| } | ||
|
|
||
| private fun getServiceStatus( |
There was a problem hiding this comment.
suggestion (non-blocking): this has a lot of important logic, would it be worth unit testing independently?
There was a problem hiding this comment.
Hm, possibly. The behavior in the existing tests was meant to cover everything here, so it would probably be a bit redundant, but it's not a bad idea.
|
RE: Station alerts, there aren't any real ones rn, but I made one in dev alerts UI:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: Stop icons on map reflect current alerts
Backend PR: mbta/mobile_app_backend#109
Show alert icons on stops for partial alerts, and red X icons for completely closed stops.
Testing
Added unit tests for kotlin alert to stop association, and for the map GeoJSON stop source generation