refactor: look up nearby stop IDs in global response #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boringcactus
force-pushed
the
mth-nearby-stops-only
branch
from
262eea5 to
e2f8bd5
Compare
# Conflicts: # iosApp/iosApp/ContentView.swift
BrandonTR
approved these changes
Apr 2, 2024
| guard let stopOnRoute = stopsById[childStopId] else { return nil } | ||
| guard let stop = stopOnRoute.resolveParent(stopsById) else { return nil } | ||
| guard let stopOnRoute = stops[childStopId] else { return nil } | ||
| guard let stop = stopOnRoute.resolveParent(stops) else { return nil } |
There was a problem hiding this comment.
Could combine these into one guard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: none
Paired with mbta/mobile_app_backend#106, uses the global response as the source of truth for details about nearby routes and stops, since all that data will be loaded regardless.
Moves the
GlobalFetcher.getGlobalDatacall outside of the map, since multiple pages use that data.Testing
Manually verified continuing functionality and updated tests to match new behavior.