fix(LocationAuthButton): Don't flash in at startup (#505)

mbta · Oct 30, 2024 · a80b487 · a80b487
1 parent a41baa5
commit a80b487
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 9 deletions.
diff --git a/iosApp/iosApp/ComponentViews/LocationAuthButton.swift b/iosApp/iosApp/ComponentViews/LocationAuthButton.swift
@@ -76,10 +76,10 @@ struct LocationAuthButton: View {
                     )
                 }
             )
-        case .authorizedAlways, .authorizedWhenInUse:
+        case .authorizedAlways, .authorizedWhenInUse, nil:
             EmptyView()
         @unknown default:
-            Text("Location access state unknown")
+            EmptyView()
         }
     }
 }
diff --git a/iosApp/iosApp/Localizable.xcstrings b/iosApp/iosApp/Localizable.xcstrings
@@ -2525,6 +2525,7 @@
       }
     },
     "Location access denied or restricted" : {
+      "extractionState" : "stale",
       "localizations" : {
         "es" : {
           "stringUnit" : {
@@ -2565,6 +2566,7 @@
       }
     },
     "Location access state unknown" : {
+      "extractionState" : "stale",
       "localizations" : {
         "es" : {
           "stringUnit" : {
@@ -2739,15 +2741,15 @@
         }
       }
     },
-    "Nearby Transit" : {
-      "comment" : "Header for nearby transit sheet"
-    },
     "Monday through Friday: 6:30 AM - 8 PM" : {
       "comment" : "Footnote under the More page support header, these are the hours for the support call center"
     },
     "mTicket App" : {
       "comment" : "Footnote underneath the \"Commuter Rail and Ferry tickets\" label on the More page link to the MBTA mTicket app"
     },
+    "Nearby Transit" : {
+      "comment" : "Header for nearby transit sheet"
+    },
     "Next stop" : {
       "comment" : "Label for a vehicle's next stop. For example: Next stop Alewife",
       "localizations" : {
@@ -3265,6 +3267,7 @@
       }
     },
     "Settings" : {
+      "comment" : "More page section header, includes settings that the user can configure",
       "localizations" : {
         "es" : {
           "stringUnit" : {
@@ -3302,8 +3305,7 @@
             "value" : "設定"
           }
         }
-      },
-      "comment" : "More page section header, includes settings that the user can configure"
+      }
     },
     "Severe Weather" : {
       "comment" : "Possible alert cause",

diff --git a/iosApp/iosApp/LocationDataManager.swift b/iosApp/iosApp/LocationDataManager.swift
@@ -13,7 +13,7 @@ import Foundation
 public class LocationDataManager: NSObject, LocationFetcherDelegate, ObservableObject {
     var locationFetcher: LocationFetcher
     @Published public var currentLocation: CLLocation?
-    @Published public var authorizationStatus = CLAuthorizationStatus.notDetermined
+    @Published public var authorizationStatus: CLAuthorizationStatus?
 
     public init(
         locationFetcher: LocationFetcher = CLLocationManager(),

diff --git a/iosApp/iosAppTests/LocationDataManagerTests.swift b/iosApp/iosAppTests/LocationDataManagerTests.swift
@@ -26,7 +26,7 @@ final class LocationDataManagerTests: XCTestCase {
 
         let manager = LocationDataManager(locationFetcher: locationFetcher)
 
-        XCTAssertEqual(manager.authorizationStatus, .notDetermined)
+        XCTAssertEqual(manager.authorizationStatus, nil)
         XCTAssertNil(manager.currentLocation)
         XCTAssertIdentical(manager, locationFetcher.locationFetcherDelegate)