feat(UpcomingTrip): Only show BRD when <= 90 seconds (#127)

mbta · Apr 12, 2024 · 8588c37 · 8588c37
1 parent 3338e4f
commit 8588c37
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 1 deletion.
diff --git a/shared/src/commonMain/kotlin/com/mbta/tid/mbta_app/model/Prediction.kt b/shared/src/commonMain/kotlin/com/mbta/tid/mbta_app/model/Prediction.kt
@@ -8,6 +8,7 @@ import kotlinx.serialization.Serializable
 
 val ARRIVAL_CUTOFF = 30.seconds
 val APPROACH_CUTOFF = 60.seconds
+val BOARDING_CUTOFF = 90.seconds
 val DISTANT_FUTURE_CUTOFF = 60.minutes
 
 @Serializable

diff --git a/shared/src/commonMain/kotlin/com/mbta/tid/mbta_app/model/UpcomingTrip.kt b/shared/src/commonMain/kotlin/com/mbta/tid/mbta_app/model/UpcomingTrip.kt
@@ -123,7 +123,8 @@ data class UpcomingTrip(
         if (
             vehicle?.currentStatus == Vehicle.CurrentStatus.StoppedAt &&
                 vehicle.stopId == prediction.stopId &&
-                vehicle.tripId == prediction.tripId
+                vehicle.tripId == prediction.tripId &&
+                timeRemaining <= BOARDING_CUTOFF
         ) {
             return Format.Boarding
         }

diff --git a/shared/src/commonTest/kotlin/com/mbta/tid/mbta_app/model/UpcomingTripTest.kt b/shared/src/commonTest/kotlin/com/mbta/tid/mbta_app/model/UpcomingTripTest.kt
@@ -101,6 +101,30 @@ class UpcomingTripTest {
             )
         }
 
+        @Test
+        fun `not boarding when stopped at stop but more than 90 seconds until departure`() {
+            val now = Clock.System.now()
+            val vehicle = vehicle {
+                currentStatus = Vehicle.CurrentStatus.StoppedAt
+                stopId = "12345"
+                tripId = "trip1"
+            }
+            assertEquals(
+                Format.Minutes(2),
+                UpcomingTrip(
+                        trip {},
+                        prediction {
+                            departureTime = now.plus(95.seconds)
+                            stopId = "12345"
+                            tripId = "trip1"
+                            vehicleId = vehicle.id
+                        },
+                        vehicle
+                    )
+                    .format(now)
+            )
+        }
+
         @Test
         fun `not boarding`() {
             val now = Clock.System.now()