Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap in new trip planner with a monitor update #2303

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

anthonyshull
Copy link
Contributor

@anthonyshull anthonyshull commented Jan 6, 2025

@anthonyshull anthonyshull requested a review from a team as a code owner January 6, 2025 16:23
@anthonyshull anthonyshull marked this pull request as draft January 6, 2025 16:23
Copy link
Collaborator

@thecristen thecristen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works!

I notice you deleted the old trip plan controller but stopped short at removing corresponding trip plan view or the associated templates, how come?

@anthonyshull
Copy link
Contributor Author

It works!

I notice you deleted the old trip plan controller but stopped short at removing corresponding trip plan view or the associated templates, how come?

I can remove most of those too, but we still use some code from the view. I can remove the rest, but really only removed the controller because it had failing function calls like trip_plan_path.

Copy link
Collaborator

@thecristen thecristen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does the job! There's so much more to clean up, but that can be done in a followup.

@thecristen thecristen removed the dev-green Deploy to dev-green label Jan 6, 2025
Copy link
Contributor

@joshlarson joshlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty exciting!

Non-blocking nit: I think we also want to remove the trip planner preview from the admin page. Non-blocking because that is low-impact and could easily be done as a follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge ⏳ it's waiting on something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants