-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap in new trip planner with a monitor update #2303
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works!
I notice you deleted the old trip plan controller but stopped short at removing corresponding trip plan view or the associated templates, how come?
I can remove most of those too, but we still use some code from the view. I can remove the rest, but really only removed the controller because it had failing function calls like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does the job! There's so much more to clean up, but that can be done in a followup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty exciting!
Non-blocking nit: I think we also want to remove the trip planner preview from the admin page. Non-blocking because that is low-impact and could easily be done as a follow-up.
https://app.asana.com/0/555089885850811/1209078853452837/f
I also did https://app.asana.com/0/555089885850811/1209078853452832/f as that needs to be shipped with this change.