update cancelled trips group filter to only cancel a trip if all stus are skipped for bus/route_type 3

[bfauble]

Summary of changes

Asana Ticket: 🐛 [Investigate] Subway passthrough trips in Concentrate have schedule_relationship CANCELED

• store route type for trips along with route_id and direction_id
• check route_type before applying :CANCELED status to trip when all stop time updates are :SKIPPED

[Whoops]

Checking my understanding, passthrough trips are nonrevenue trips where a train will pass through a station but won't pick up passengers, right? And they are currently being represented by a trip with all skipped stops?

So the idea here is that bus does not have these passthrough trips, so if we have all skipped stops it's a block waiver and we should cancel them, but subway it could be a passthrough?

I'm wondering if this is a safe assumption (that this logic should only every apply to bus, not Subway). Would it be possible to check the revenue status of the trip instead, or can we not rely on it being marked nonrevenue?

[bfauble]

So the idea here is that bus does not have these passthrough trips, so if we have all skipped stops it's a block waiver and we should cancel them, but subway it could be a passthrough?

This is my understanding of the intent of the original change to add the cancellation of the block based on all skipped stus which was inadvertently also catching rail trips from time to time.

[Whoops]

Not seeing any glaring issues in dev-green, I think this is good to go.

[Whoops]

I re-enabled CI (thanks Github for auto-disabling, SUPER helpful). I don't seem to be able to kick it into reruning for this though, I think you might have to re-push?

[Whoops]

Even better CI is blocked because they have decided we need to use a newer version of upload-artifact. Fix is in this PR. I'm stepping away for an hour or so, if you want feel free to merge that after approving to unblock this PR.

[Whoops]

I think the code in this version is easier to follow than the original, and it's looking good after running in dev blue for awhile 👍