support baidu translator api #208
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, this looks very interesting, I'd love to include this as a new feature, but tests are failing. Would you mind fix them? Thanks! |
|
@yihuang thanks again for this and sorry for sitting on it so long. I've update my local branch with the latest changes from upstream and I'm kind of ready to merge this, but I'd really like to test this before going forward, and I'm having a hard time trying to obtain an API key from Baidu to test with (mostly because I don't speak Chinese) Do you think you could help me out on this and instruct me on how to get a key? Thanks! |
|
I can send you my personal key in private if you give me your email address. |
|
@yihuang Can you rebase this PR to get it in a state that allows merging, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
pip install tox && tox)