Feature/46 producttype nl datamodel #2
Conversation
|
Something to consider: the If I remember correctly, there is a command to do this. Can run when everything is added. |
There was a problem hiding this comment.
Important things:
- Productype admin has a typo breaking the change list
- Vraag is missing all help_texts.
- Price does not allow two prices with different product types to have the same start date
Moderately important stuff:
- Markdownx fields are vague on what they actually support
- UPN importer logging could be clearer
- Aspects of UPN importer not being tested
- Request mock or VCR for importing from URL (to see if it gives the data you want)
- Onderwerpen model tests (for published conditions)
Not really import (QOL)
- Search fields and filters in the admin might be useful
- UPN importer & parser refactoring
- Transaction atomic
- Explicitly require url or local file and do not infer
- Deal with or log duplicate values
- Remove Temp file
src/open_producten/producttypen/management/commands/load_upl.py
Outdated
Show resolved
Hide resolved
| def has_change_permission(self, request, obj=None): | ||
| if obj and obj.actief_vanaf < datetime.today().date(): | ||
| return False | ||
| return super().has_change_permission(request, obj) |
There was a problem hiding this comment.
I still feel that this will come up as an issue in the future, but tomorrows problems are for tomorrow's me.
And by me I mean you.
|
|
||
| self.stdout.write(f"Done ({created_count} objects).") | ||
| response = requests.get(url) | ||
| if response.status_code != 200: |
There was a problem hiding this comment.
Not sure if you intended it, but this will not catch 400 or 500 codes, only different 200 and 300 codes
There was a problem hiding this comment.
requests throws exceptions for those codes
|
|
||
| UniformProductNaamModel.objects.exclude(id__in=upn_updated_list).update( | ||
| removed_count = UniformProductNaamModel.objects.exclude( |
There was a problem hiding this comment.
This gets the count but IDK how. Should it not return a queryset? or is str(querset) always the count?
There was a problem hiding this comment.
.update() returns the number of affected rows.
docs
Add the productypen app.
Changes from prototype