✨ [open-zaak/open-notificaties#207] Update existing with register_kanalen #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenbal
force-pushed
the
feature/register-kanalen-update
branch
from
06d335c to
4067515
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
+ Coverage 90.19% 93.01% +2.81%
==========================================
Files 29 38 +9
Lines 602 988 +386
==========================================
+ Hits 543 919 +376
- Misses 59 69 +10 ☔ View full report in Codecov by Sentry. |
stevenbal
force-pushed
the
feature/register-kanalen-update
branch
from
4067515 to
98ef5b7
Compare
stevenbal
force-pushed
the
feature/register-kanalen-update
branch
from
98ef5b7 to
bcd1296
Compare
swrichards
approved these changes
Dec 18, 2024
notifications_api_common/management/commands/register_kanalen.py
Outdated
Show resolved
Hide resolved
notifications_api_common/management/commands/register_kanalen.py
Outdated
Show resolved
Hide resolved
notifications_api_common/management/commands/register_kanalen.py
Outdated
Show resolved
Hide resolved
stevenbal
force-pushed
the
feature/register-kanalen-update
branch
from
bcd1296 to
d798d77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes open-zaak/open-notificaties#207
Required for open-zaak/open-notificaties#156
This does require Open Notificaties to allow PUT to Kanalen (which the spec doesn't allow right now), see open-zaak/open-notificaties#208