✨ [open-zaak/open-notificaties#156] Several changes to Kanalen

[stevenbal]

Related issue: open-zaak/open-notificaties#156

Requires zgw-consumers to be upgraded in Open Zaak

Changes:

• Support nested fields on kanaal kenmerken

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.21%. Comparing base (7abd32e) to head (68c8ba8).

Files with missing lines	Patch %	Lines
notifications_api_common/kanalen.py	92.85%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
- Coverage   89.23%   89.21%   -0.03%     
==========================================
  Files          29       29              
  Lines         604      612       +8     
==========================================
+ Hits          539      546       +7     
- Misses         65       66       +1     

Flag	Coverage Δ
	89.21% <93.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[alextreme]

@stevenbal see if you can revisit this PR next week now that open-zaak/open-zaak#1800 has been completed

[Coperh]

Support nested fields on kanaal kenmerken

I guess this is suppose the extra_kwargs[kenmerk_1][field_name] and is for supporting stuff added in open zaak rather than here?

Have some comments and I do not think the nested fields are actually tested or at least the help text

[Coperh]

What does this request do?

[Coperh]

Could this just not be in data?

edit: actually probably not

[Coperh]

Actually again this is something fore open zaak?

[stevenbal]

You're right, this is necessary for Open Zaak to create the URLs: https://github.com/open-zaak/open-zaak/pull/1757/files#diff-b74ad95db3a00961f14403f57ab65597401cc8b8b1ef88e162d3214c4baf70d6R54.

data is the actual request data (JSON) that is posted, so it can't really be a part of that I think

[stevenbal]

I guess this is suppose the extra_kwargs[kenmerk_1][field_name] and is for supporting stuff added in open zaak rather than here?

that's right, I've added the help_text stuff to be able to mark the help text for zaaktype.catalogus as experimental in Open Zaak

[Coperh]

Yep, looks good.

[annashamray]

Looks good