changed disable_admin_mfa test util func name to disable_mfa #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -50,3 +50,6 @@ def get_valid_totp_token(user: AbstractBaseUser) -> str: | |||
| if not isinstance(device, TOTPDevice): | |||
| raise ValueError("The user's default device is not a TOTPDevice.") | |||
| return _totp_str(device.bin_key) | |||
|
|
|||
|
|
|||
| disable_admin_mfa = disable_mfa | |||
There was a problem hiding this comment.
Suggested change
| disable_admin_mfa = disable_mfa | |
| disable_admin_mfa = disable_mfa | |
| """ | |
| Test helper to disable MFA requirements in the admin. | |
| Note that this is the same as :func:`disable_mfa`, because the `user.is_verified` | |
| check is added via middleware which applies to the entire project and not just | |
| the admin. However, this alias exists because maykin-2fa deliberately scopes | |
| itself to managing access to the admin interface. Use the name that best conveys | |
| your intent in your test cases. | |
| """ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the
disable_admin_mfadecorator name to the more accurate namedisable_mfa.