Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Family invites #1397

Merged
merged 22 commits into from
Nov 1, 2024
Merged

Family invites #1397

merged 22 commits into from
Nov 1, 2024

Conversation

Shpigford
Copy link
Member

@Shpigford Shpigford commented Oct 31, 2024

Adds the ability to invite family members to your account.

  • Figure out how this works in a self-hosted environment
  • Make sure email formatting looks passable
  • Update add member modal to match Figma design
  • Show/format pending invites in the member list
  • Write some basic tests

@Shpigford
Copy link
Member Author

@zachgoll Thoughts on the self-hosted version of this? Instead of email invites we could just have the admin add a user with a password (then it's their responsibility to give that to whomever they want)? Other option is just show them the invitation URL for them to copy/paste and share on their own?

Copy link
Collaborator

@zachgoll zachgoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good.

In regards to self hosters, I think this should work fine

  • If a self hoster wants to invite a member to their family, they use this flow (they'll have to configure SMTP on their own, but I think that's reasonable?)
  • If a self hoster wants to allow someone else to sign up for their instance, they use the invite codes flow

CleanShot 2024-10-31 at 08 44 48

app/controllers/onboardings_controller.rb Show resolved Hide resolved
app/controllers/registrations_controller.rb Show resolved Hide resolved
@zachgoll
Copy link
Collaborator

@Shpigford I guess the one consideration for self hosting that may not work with the email config is users running things on a local network.

Rather than having to worry about SMTP stuff, I think I like your idea of just generating a URL with a token that they can copy/paste and send to whoever they want. Since we've got an expiry on the Invitation that seems reasonable.

@Shpigford Shpigford marked this pull request as ready for review November 1, 2024 15:15
@Shpigford Shpigford merged commit 793bd85 into main Nov 1, 2024
5 checks passed
@Shpigford Shpigford deleted the family-invites branch November 1, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants