Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac dependency script #12281

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Mac dependency script #12281

merged 1 commit into from
Jan 5, 2025

Conversation

DonLakeFlyer
Copy link
Contributor

No description provided.

@DonLakeFlyer DonLakeFlyer requested a review from HTRamsey January 4, 2025 21:11
@HTRamsey
Copy link
Collaborator

HTRamsey commented Jan 4, 2025

should we call this from the workflow macos.yml?

@DonLakeFlyer
Copy link
Contributor Author

I guess, it depends. Which path is more important to verify in CI? With or without pre-installed libs?

@DonLakeFlyer
Copy link
Contributor Author

I guess the docs say to install the libs so that's the would be the one to replicate in CI.

@DonLakeFlyer
Copy link
Contributor Author

@HTRamsey Can you take another look?

@HTRamsey
Copy link
Collaborator

HTRamsey commented Jan 5, 2025

I think you'll still want the continue-on-error: true because it'll pop an error if one of the downloads fails or something, at which case we can rely on cmake to just build the dependency

@DonLakeFlyer
Copy link
Contributor Author

I specifically left that out so that we will know if availability of something from brew changes. When that happens we will need to update the dependencies script. That seems helpful. But I get the download thing. If that seems to crap out a lot abd become and annoyance then we could add it back?

@HTRamsey
Copy link
Collaborator

HTRamsey commented Jan 5, 2025

I think the task still actually shows as failing it just continues anyways, so it should still be obvious that something needs to be done but at least you'll know the build is okay

@DonLakeFlyer
Copy link
Contributor Author

I think the task still actually shows as failing it just continues anyways

I just tried it and unless you specifically open up the depedencies task you'd have no idea it failed. I'm gone it leave it as failing if brew screws up.

Run from CI as well
@DonLakeFlyer DonLakeFlyer merged commit 9ba96c3 into master Jan 5, 2025
10 checks passed
@DonLakeFlyer DonLakeFlyer deleted the MacDependencies branch January 5, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants