-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mac dependency script #12281
Mac dependency script #12281
Conversation
should we call this from the workflow macos.yml? |
I guess, it depends. Which path is more important to verify in CI? With or without pre-installed libs? |
I guess the docs say to install the libs so that's the would be the one to replicate in CI. |
f40399d
to
48e4180
Compare
@HTRamsey Can you take another look? |
I think you'll still want the |
I specifically left that out so that we will know if availability of something from brew changes. When that happens we will need to update the dependencies script. That seems helpful. But I get the download thing. If that seems to crap out a lot abd become and annoyance then we could add it back? |
I think the task still actually shows as failing it just continues anyways, so it should still be obvious that something needs to be done but at least you'll know the build is okay |
I just tried it and unless you specifically open up the depedencies task you'd have no idea it failed. I'm gone it leave it as failing if brew screws up. |
Run from CI as well
46a83de
to
1a20e38
Compare
No description provided.