Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan: Only load editor if current item #12258

Merged
merged 1 commit into from
Dec 27, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/PlanView/MissionItemEditor.qml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import QGroundControl.Palette
/// Mission item edit control
Rectangle {
id: _root
height: editorLoader.visible ? (editorLoader.y + editorLoader.height + _innerMargin) : (topRowLayout.y + topRowLayout.height + _margin)
height: _currentItem ? (editorLoader.y + editorLoader.height + _innerMargin) : (topRowLayout.y + topRowLayout.height + _margin)
color: _currentItem ? qgcPal.missionItemEditor : qgcPal.windowShade
radius: _radius
opacity: _currentItem ? 1.0 : 0.7
Expand Down Expand Up @@ -277,8 +277,7 @@ Rectangle {
anchors.margins: _innerMargin
anchors.left: parent.left
anchors.top: topRowLayout.bottom
source: missionItem.editorQml
visible: _currentItem
source: _currentItem ? missionItem.editorQml : ""

property var masterController: _masterController
property real availableWidth: _root.width - (anchors.margins * 2) ///< How wide the editor should be
Expand Down
Loading