bugfix: Stop calibration when disconnect battery is received #11987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing bug where more popups open when relaunching ESC calibration
Description
Tested with px4.
Launching ESC calibration without battery status fails the
check_battery_disconnect()insrc/modules/commander/esc_calibration.cpp(px4-autopilot)Disconnect battery and try againstatus is sent.but QGC does not unsubscribe
_handleVehicleTextMessagebecause_stopCalibrationis not called (early exit)-> causes stacking of popups the more we run ESC calibration
Test Steps
Launch ESC calibration without battery status for FC (eg no battery, FC powered by directly).
An error message appears: "Disconnect battery and try again"
Relaunch again
Same error message, this time only a single popup (because
_stopCalibrationunsubscribes_handleVehicleTextMessage)Checklist:
Related Issue