Fix view switch FactTextField validation checks

Can't call signal handlers in Qt 6.8
mavlink · Jan 9, 2025 · 0085c5c · 0085c5c
1 parent 539459e
commit 0085c5c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/FactSystem/FactControls/FactTextField.qml b/src/FactSystem/FactControls/FactTextField.qml
@@ -19,7 +19,9 @@ QGCTextField {
 
     property Fact fact: null
 
-    onEditingFinished: {
+    onEditingFinished: _onEditingFinished()
+
+    function _onEditingFinished() {
         var errorString = fact.validate(text, false /* convertOnly */)
         if (errorString === "") {
             clearValidationError()

diff --git a/src/UI/MainRootWindow.qml b/src/UI/MainRootWindow.qml
@@ -16,6 +16,7 @@ import QtQuick.Window
 import QGroundControl
 import QGroundControl.Palette
 import QGroundControl.Controls
+import QGroundControl.FactControls
 import QGroundControl.ScreenTools
 import QGroundControl.FlightDisplay
 import QGroundControl.FlightMap
@@ -113,8 +114,8 @@ ApplicationWindow {
     // This function is used to prevent view switching if there are validation errors
     function allowViewSwitch(previousValidationErrorCount = 0) {
         // Run validation on active focus control to ensure it is valid before switching views
-        if (mainWindow.activeFocusControl instanceof QGCTextField) {
-            mainWindow.activeFocusControl.onEditingFinished()
+        if (mainWindow.activeFocusControl instanceof FactTextField) {
+            mainWindow.activeFocusControl._onEditingFinished()
         }
         return globals.validationErrorCount <= previousValidationErrorCount
     }