Docker Support #94
Merged
Docker Support #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericjohnson97
commented
Feb 8, 2024
| @@ -0,0 +1,28 @@ | |||
| # Build | |||
There was a problem hiding this comment.
@patrickelectric I am not sure if you would like to have a separate build container for building or if you prefer it like this. let me know and I can adjust it.
ericjohnson97
commented
Feb 8, 2024
Dockerfile
Outdated
|
|
||
| RUN chmod +x mavlink2rest | ||
|
|
||
| ENTRYPOINT ./mavlink2rest -c ${MAVLINK_SRC} -s ${SERVER_PORT} |
There was a problem hiding this comment.
Can we add an env variable for generic arguments ?
There was a problem hiding this comment.
let me know what you think of the revised args
|
@patrickelectric Let me know what you think of this dockerfile. If this is not what you want or would like to do it a different way, I understand. I can either revise or let you do it in some time in the future. |
patrickelectric
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR runtime docker support