-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vitepress test branch #292
base: main
Are you sure you want to change the base?
Conversation
Thanks @hamishwillee. What am I doing wrong?
Edit: ah presumably I need to install npm and yarn and what not. |
Yes, that's right. D Note that this is "somewhat deprecated" in favour of mavlink/MAVSDK#2490 since you want to have this as part of the main repo. That is waiting on me being able to build the latest main - which as we discussed some weeks ago was failing due to open ssl issues. Were those resolved, or is it still just me? |
Ok, I'll check over there. I was hesitating to move it over because we need to have it for 3 versions, and I was wondering whether that's possible in the main repo. |
You can have it for three versions in the main repo. The thing is though, if you want to modify the docs in a particular version later, they will need their own branch, just as you would for code changes. I think you're mostly working with tags for versions now - right? EDIT The thing to realize here is that the sources change, but the generated docs do not - the sources that are published are in a separate publication branch that uses a folder structure to separate the versions. |
We have a branch per major version, so v1, v2, and I'm going to create a v3 as well to not confuse it with main. |
Do I understand it right that assuming an external repo (like this), we would generate from the v1, v2, v3 branches and create the docs in 3 subfolders here. If it was within the same repo, then we need some sort of pipeline set up that would get the v1, v2, v3 branches, auto-generate from each, and then combine it in a subsequent step? |
Nearly. So the deployment is to https://github.com/mavlink/mavsdk.mavlink.io and we use exactly the same process as currently. When we do a build of branch "X" we delete the X folder, and recreate it with a new build of the respective branch. The other branches remain unchanged. The deploy will be based on the PX4 one, which does this https://github.com/PX4/PX4-user_guide/blob/main/.github/workflows/docs_deploy.yml#L82-L96 The actual target of the deployment is that separate repo. make sense? I could set this up now, but I'd like to be sure the reference builds properly first. |
Ok, I think that could work, and basically would work from the main MAVSDK repo as well. |
Yes it will work from anywhere because sources and deployment are always separated. The benefit is that we don't have to rebuild the old versions with the new toolchain, we can just start from main. Note that the new toolchain does have one irritation though. The version switcher is hard coded in each build, while in github the versions are fetched from book.json in main. So as we add new builds we will have to update the old builds to include the new version. |
This is an initial test build of vitepress build of MAVSDK. You can test it by cloning, and in the root of the installation running
Then navigate to suggested URL.
It Fixes up sidebars and nav.
Things to do:
@julianoes Have peak when you get a chance. If you think it is more or less heading in the right direction then we can push it further.