Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(Edit Attachments): Add tests cases for edit attachments #196

Merged
merged 5 commits into from
Dec 13, 2024

Conversation

yasserfaraazkhan
Copy link
Collaborator

@yasserfaraazkhan yasserfaraazkhan commented Dec 5, 2024

data/test-cases/channels/edited-post/1-Edit-Attachment.md Outdated Show resolved Hide resolved
3. Use the "Attach" button (paperclip icon) to upload a file.
4. Save the edited post.
5. Verify the attachment is visible.
6. Verify a `Added today` label is shown.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this label show? I don't recall seeing this in the designs

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marianunez it was here.
I think the new attachments will have the date/time on them

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marianunez
would this be out of scope ?

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yasserfaraazkhan yes the tooltip displayed in last screen is out of scope. We'll keep the existing tooltip on edit.

Copy link
Member

@marianunez marianunez Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshilsharma63 so you are extending the edited tooltip to say Attachment added?

data/test-by-folder.json Outdated Show resolved Hide resolved
data/test-by-folder.json Show resolved Hide resolved
data/test-cases/channels/edited-post/1-Edit-Attachment.md Outdated Show resolved Hide resolved
3. Use the "Attach" button (paperclip icon) to upload a file.
4. Save the edited post.
5. Verify the attachment is visible.
6. Verify a `Added today` label is shown.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yasserfaraazkhan yes the tooltip displayed in last screen is out of scope. We'll keep the existing tooltip on edit.


- A post with at least one attachment exists. This post should have been edited.
- Data retention policy is enabled.
- The edited date of the post with attachments should be beyond the file retention and post retention days set.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to check if we delete old versions of a post if only an edit is beyond the data retention period while the latest post version is within.

Copy link
Member

@marianunez marianunez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@lindalumitchell lindalumitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple spelling nits. Looks good!

data/test-cases/channels/edited-post/5-Channel-files.md Outdated Show resolved Hide resolved
6. Verify the post is updated. The files are not visible to other users.
7. Verify the Channel files do not have the attachment anymore.

### Scenario 4: Verify user cannot see the post and file in the edit history if the data retension policy date has past.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Scenario 4: Verify user cannot see the post and file in the edit history if the data retension policy date has past.
### Scenario 4: Verify user cannot see the post and file in the edit history if the data retention policy date has past.

@yasserfaraazkhan yasserfaraazkhan merged commit 2884fc5 into main Dec 13, 2024
1 check passed
@yasserfaraazkhan yasserfaraazkhan deleted the MM-62056 branch December 13, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants