-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(Edit Attachments): Add tests cases for edit attachments #196
Conversation
3. Use the "Attach" button (paperclip icon) to upload a file. | ||
4. Save the edited post. | ||
5. Verify the attachment is visible. | ||
6. Verify a `Added today` label is shown. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does this label show? I don't recall seeing this in the designs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marianunez it was here.
I think the new attachments will have the date/time on them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marianunez
would this be out of scope ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yasserfaraazkhan yes the tooltip displayed in last screen is out of scope. We'll keep the existing tooltip on edit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@harshilsharma63 so you are extending the edited tooltip to say Attachment added
?
3. Use the "Attach" button (paperclip icon) to upload a file. | ||
4. Save the edited post. | ||
5. Verify the attachment is visible. | ||
6. Verify a `Added today` label is shown. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yasserfaraazkhan yes the tooltip displayed in last screen is out of scope. We'll keep the existing tooltip on edit.
|
||
- A post with at least one attachment exists. This post should have been edited. | ||
- Data retention policy is enabled. | ||
- The edited date of the post with attachments should be beyond the file retention and post retention days set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to check if we delete old versions of a post if only an edit is beyond the data retention period while the latest post version is within.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yasserfaraazkhan!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple spelling nits. Looks good!
6. Verify the post is updated. The files are not visible to other users. | ||
7. Verify the Channel files do not have the attachment anymore. | ||
|
||
### Scenario 4: Verify user cannot see the post and file in the edit history if the data retension policy date has past. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Scenario 4: Verify user cannot see the post and file in the edit history if the data retension policy date has past. | |
### Scenario 4: Verify user cannot see the post and file in the edit history if the data retention policy date has past. |
EPIC: https://mattermost.atlassian.net/browse/MM-59495
JIRA: https://mattermost.atlassian.net/browse/MM-62056