Skip to content

Commit

Permalink
review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
yasserfaraazkhan committed Sep 25, 2024
1 parent 7d733b9 commit 4d11176
Show file tree
Hide file tree
Showing 8 changed files with 63 additions and 63 deletions.
8 changes: 4 additions & 4 deletions data/test-by-folder.json
Original file line number Diff line number Diff line change
Expand Up @@ -1601,11 +1601,11 @@
"tests": [
"Verify User can Delete a scheduled message in DM/GM/Channel",
"Verify User can Edit a scheduled message in DM/GM/Channel",
"Verify User can create a Schedule message from the Draft Page",
"Verify User can create a scheduled message from the Drafts Page",
"Verify User can create a scheduled message in DM/GM/Channel",
"Verify User can identify the cases for Failed scheduled message",
"Verify User can remove scheduled setting from the Scheduled message",
"Verify if the Failed Scheduled message is sent out after server recovered from and Outage issue"
"Verify User can identify the cases for failed scheduled message",
"Verify User can remove scheduled setting from a scheduled message",
"Verify if the Failed scheduled message is sent out after server recovered from an outage issue"
]
},
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ folder: Schedule Messages
authors: "@yasserfaraazkhan"
team_ownership:
- ICU
priority_p1_to_p4: P2 - Core Functions (Do core functions work?)
priority_p1_to_p4: P3 - Deep Functions (Do extensive scenarios work?)

# (Optional)
location: null
Expand Down Expand Up @@ -43,16 +43,16 @@ Steps:
2. Type a message in the GM/Channel post text box.
3. Click on the Dropdown beside Send button.
4. Choose a pre-defined Date from the options.
5. Verify the message is scheduled and user can see one of the below mentioned message in the Channel
- If the message is scheduled for today, show “Messages scheduled for today at 3:00 PM.”
- If the message is scheduled for the next day, show “Messages scheduled for tomorrow at 3:00 PM.”
5. Verify the message is scheduled and user can see one of the below mentioned messages in the Channel
- If the message is scheduled for today, show “Message scheduled for today at 3:00 PM.”
- If the message is scheduled for the next day, show “Message scheduled for tomorrow at 3:00 PM.”
- If the message is scheduled within a week, show “Message scheduled for Monday at 3:00 PM.”
- If the message is scheduled >= 1 week, show “Message scheduled for Oct 16 at 3:00 PM.”
6. Verify User can see an option `See all scheduled messages`.
7. Click on `See all scheduled messages`.
8. Verify use is taken to Scheduled tab and can see the Scheduled messages.
9. The messages should have a tag `Scheduled` and the time mentioned and have one of the below message displayed
- If the message is scheduled for today, show “Send today at 3:00 PM”.
8. Verify user is taken to Scheduled tab and can see the Scheduled messages.
9. The messages should have a tag `Scheduled` and the time mentioned and have one of the below messages displayed
- If the message is scheduled for today, show “Send today at 3:00 PM”
- If the message is scheduled for the next day, show “Send tomorrow at 3:00 PM”
- If the message is scheduled within a week, show “Send Monday at 3:00 PM”
- If the message is scheduled >= 1 week, show “Send Oct 16 at 3:00 PM”
Expand All @@ -65,14 +65,14 @@ Steps:
### Scenario 3: Able to schedule a message in a DM.

1. Log into User's account.
2. Open a Dirent message with User A.
2. Open a Direct message with User A.
3. Type a message in the text box.
4. Click on the Dropdown beside Send button. example: Tomorrow at 9:00 AM
- If the User A is in different timezone. the option should show `Tomorrow at 9:00 AM. 10:00 AM User A's time`.
5. Choose a pre-defined Date from the options.
6. Verify the message is scheduled and user can see the message `Your draft has been scheduled for tomorrow at 9:00 AM <current user's time zone>`.
7. Click on `See all scheduled messages`.
8. Verify use is taken to Scheduled tab and can see the Scheduled message.
8. Verify user is taken to Scheduled tab and can see the Scheduled message.

### Scenario 4: Able to schedule a message on a custom time in GM/Channel

Expand All @@ -83,7 +83,7 @@ Steps:
5. Verify a modal is opened and by default the date is set to `Tomorrow` and time is `09:00 AM`
- If its a DM then the Modal should show time on which user will receive the message. Example: `<Day> at <time> for Username`.
6. Click on `See all scheduled messages`.
7. Verify use is taken to Scheduled tab and can see the Scheduled message.
7. Verify user is taken to Scheduled tab and can see the Scheduled message.

### Scenario 5: Able to schedule a message within a Threaded message with no replies

Expand All @@ -92,11 +92,11 @@ Steps:
3. Open the thread on the RHS.
4. Schedule a message.
5. Verify user can see a message saying `You have <#Number> scheduled message. <link> See all <link>`
6. Goto Threads page.
6. Go to Threads page.
7. Open the thread where above message is scheduled.
8. Verify user can see on of the below message
- If the message is scheduled for today, show “Messages scheduled for today at 3:00 PM.”
- If the message is scheduled for the next day, show “Messages scheduled for tomorrow at 3:00 PM.”
8. Verify user can see one of the below messages
- If the message is scheduled for today, show “Message scheduled for today at 3:00 PM.”
- If the message is scheduled for the next day, show “Message scheduled for tomorrow at 3:00 PM.”
- If the message is scheduled within a week, show “Message scheduled for Monday at 3:00 PM.”
- If the message is scheduled >= 1 week, show “Message scheduled for Oct 16 at 3:00 PM.”
9. Let the scheduled message be launched.
Expand All @@ -112,11 +112,11 @@ Steps:
5. Goto Scheduled tab.
6. Verify the newly scheduled message is visible with attachments.

### Scenario 7: Able to view attachments in the scheduled
### Scenario 7: Able to view attachments in the scheduled message

1. Log into User's account.
2. Create a threaded post with attachments like Image, Video, PDF in a Channel.
3. Click on the Dropdown beside Send button.
4. Choose a pre-defined Date from the options.
5. Goto Scheduled tab.
6. Verify the newly scheduled message is visible with attachments in the scheduled tab.
5. Go to Scheduled tab.
6. Verify the newly scheduled message is visible with attachments in the Scheduled tab.
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ folder: Schedule Messages
authors: "@yasserfaraazkhan"
team_ownership:
- ICU
priority_p1_to_p4: P2 - Core Functions (Do core functions work?)
priority_p1_to_p4: P3 - Deep Functions (Do extensive scenarios work?)

# (Optional)
location: null
Expand Down Expand Up @@ -44,7 +44,7 @@ Prerequisites:
Steps:

1. Log into User's account.
2. Goto `Scheduled` tab under drafts page.
2. Go to `Scheduled` tab under Drafts page.
3. Hover on the message you want to edit.
4. Click on `Edit` icon.
5. Update the post text.
Expand All @@ -56,7 +56,7 @@ Steps:
Steps:

1. Log into User's account.
2. Goto `Scheduled` tab under drafts page.
2. Go to `Scheduled` tab under Drafts page.
3. Hover on the message you want to edit.
4. Click on `Reschedule` icon.
5. Verify a Modal is opened.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ folder: Schedule Messages
authors: "@yasserfaraazkhan"
team_ownership:
- ICU
priority_p1_to_p4: P2 - Core Functions (Do core functions work?)
priority_p1_to_p4: P3 - Deep Functions (Do extensive scenarios work?)

# (Optional)
location: null
Expand Down Expand Up @@ -44,10 +44,10 @@ Prerequisites:
Steps:

1. Log into User's account.
2. Goto `Scheduled` tab under drafts page.
2. Go to `Scheduled` tab under Drafts page.
3. Hover on the message you want to edit.
4. Click on `Delete` icon.
5. Verify a confirmation prompt is shown.
6. Click on `Confirm` button.
7. Verify the post is deleted.
8. Goto Channel and verify the Number of scheduled message is reduced.
8. Go to Channel and verify the number of scheduled message is reduced.
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
---
# (Required) Ensure all values are filled up
name: "Verify User can identify the cases for Failed scheduled message"
name: "Verify User can identify the cases for failed scheduled message"
status: Active
priority: Normal
folder: Schedule Messages
authors: "@yasserfaraazkhan"
team_ownership:
- ICU
priority_p1_to_p4: P2 - Core Functions (Do core functions work?)
priority_p1_to_p4: P3 - Deep Functions (Do extensive scenarios work?)

# (Optional)
location: null
Expand Down Expand Up @@ -45,36 +45,36 @@ Steps:

1. Log into User's account.
2. Leave the channel where a message was scheduled to be sent.
3. Goto Scheduled Tab in Drafts page.
3. Go to Scheduled tab in Drafts page.
4. Verify the Error message is on the top of the list.
5. Verify there is a Header `<number> of your scheduled drafts cannot be sent`.
6. Verify the User can see Error message `You’re not a member anymore of the channel.`.
7. Verify the message has a tag `Not in the channel` in red alert.
7. Verify the message has a tag `NOT IN THE CHANNEL` in red alert.

### Scenario 2: Should not send message if Channel is Archived.

1. Log into User's account.
2. Archive the channel where a message was scheduled to be sent.
3. Goto Scheduled Tab in Drafts page.
4. Verify the User can see Error message `Channel is archived`.
5. Verify the message has a tag `Channel is archived` in red alert.
3. Go to Scheduled tab in Drafts page.
4. Verify the User can see Error message `CHANNEL IS ARCHIEVED`.

Check failure on line 59 in data/test-cases/channels/schedule-messages/4-Failed-Schedule-Message.md

View workflow job for this annotation

GitHub Actions / test

ARCHIEVED ==> ACHIEVED, ARCHIVED
5. Verify the message has a tag `CHANNEL IS ARCHIEVED` in red alert.

Check failure on line 60 in data/test-cases/channels/schedule-messages/4-Failed-Schedule-Message.md

View workflow job for this annotation

GitHub Actions / test

ARCHIEVED ==> ACHIEVED, ARCHIVED

### Scenario 3: Should not send message if Channel is Read-only.

1. Log into Admin's account.
2. Goto Channel settings.
2. Go to Channel settings.
3. Disable `Create Posts` permission for the channel.
4. Log into User's account.
5. Goto Scheduled Tab in Drafts page.
6. Verify the User can see Error message `Channel is now read only`.
7. Verify the message has a tag `Channel is read only` in red alert.
5. Go to Scheduled tab in Drafts page.
6. Verify the User can see Error message `CHANNEL IS READ-ONLY`.
7. Verify the message has a tag `CHANNEL IS READ-ONLY` in red alert.

### Scenario 4: Should not send message if User is removed from a Private Channel.

1. Log into User's account.
2. Leave the Private channel where User had some scheduled messages.
3. Goto Scheduled Tab in Drafts page.
4. Verify the message has a tag `Not in the channel` in red alert.
3. Go to Scheduled tab in Drafts page.
4. Verify the message has a tag `NOT IN THE CHANNEL` in red alert.
5. Verify the User can see `No Channel` in the Channels section.

### Scenario 5: Verify LHS Count displayed when scheduled message fails to be sent.
Expand All @@ -84,28 +84,28 @@ Steps:
3. Leave the channel where a message was scheduled to be sent.
4. Verify the user can see Error icon in red color.
5. Hover on the Icon a tooltip saying `One of your scheduled drafts cannot be sent`.
6. Goto Scheduled Tab in Drafts page.
7. Hoven on the Failed message and delete it.
6. Go to Scheduled tab in Drafts page.
7. Hover on the Failed message and delete it.
8. Verify the Error message is not shown on the LHS anymore.

### Scenario 6: Verify Schedule message fails if the root post is moved to Private channel on the same team.

1. Log into User A's account and create a Root post in a channel.
2. Reply to the root post with some messages.
3. Log into User B's account and create a threaded schedule message to the root post.
3. Log into User B's account and create a threaded scheduled message on the root post.
4. From User A's account, Using **Move Threads** feature, move the root post to a private Channel where User B is not a member.
5. Log into User B's account.
6. Goto Scheduled messages tab.
7. Verify the message has a tag `Not in the channel` in red alert.
6. Go to Scheduled messages tab.
7. Verify the message has a tag `NOT IN THE CHANNEL` in red alert.
8. Verify the User can see `No Channel` in the Channels section.

### Scenario 7: Verify Schedule message fails if the root post is moved to another team channel.
### Scenario 7: Verify Schedule message fails if the root post is moved to another team.

1. Log into User A's account and create a Root post in a channel.
2. Reply to the root post with some messages.
3. Log into User B's account and create a threaded schedule message to the root post.
3. Log into User B's account and create a threaded scheduled message on the root post.
4. From User A's account, Using **Move Threads** feature, move the root post to another Team where User B is not a member.
5. Log into User B's account.
6. Goto Scheduled messages tab.
7. Verify the message has a tag `Not in the channel` in red alert.
6. Go to Scheduled messages tab.
7. Verify the message has a tag `NOT IN THE CHANNEL` in red alert.
8. Verify the User can see `No Channel` in the Channels section.
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
---
# (Required) Ensure all values are filled up
name: "Verify if the Failed Scheduled message is sent out after server recovered from and Outage issue"
name: "Verify if the Failed scheduled message is sent out after server recovered from an outage issue"
status: Active
priority: Normal
folder: Schedule Messages
authors: "@yasserfaraazkhan"
team_ownership:
- ICU
priority_p1_to_p4: P2 - Core Functions (Do core functions work?)
priority_p1_to_p4: P3 - Deep Functions (Do extensive scenarios work?)

# (Optional)
location: null
Expand Down Expand Up @@ -45,12 +45,12 @@ Steps:

1. Log into User's account.
2. Simulate server outage for a time period when the message was scheduled.
- Option 1: User Jmeter or k6 tool to generate huge traffic on the server.
- Option 1: Use Jmeter or k6 tool to generate huge traffic on the server.
- Option 2: If the instance is created using Cloud plugin, try options like `--database` or `hibernate`
3. Wait till the scheduled message fails due to server outage
4. Once the serer recovers, Verify if the scheduled message is sent out within 30 mins.

### Scenario 2: The server does not recover within a timestamp of 30 minutes. Messages is marked as Failed.
### Scenario 2: The server does not recover within a timestamp of 30 minutes. Message is marked as Failed.

1. Log into User's account.
2. Simulate server outage for a longer time period when the message was scheduled.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
---
# (Required) Ensure all values are filled up
name: "Verify User can create a Schedule message from the Draft Page"
name: "Verify User can create a scheduled message from the Drafts Page"
status: Active
priority: Normal
folder: Schedule Messages
authors: "@yasserfaraazkhan"
team_ownership:
- ICU
priority_p1_to_p4: P2 - Core Functions (Do core functions work?)
priority_p1_to_p4: P3 - Deep Functions (Do extensive scenarios work?)

# (Optional)
location: null
Expand Down Expand Up @@ -41,14 +41,14 @@ Steps:

1. Log into User's account.
2. Type a message in the DM/GM/Channel post text box to create a Draft message.
3. Goto Drafts page.
3. Go to Drafts page.
4. Verify the Draft is created and has channel name and date of creation.
5. Hover on the Draft.
6. Click on the Schedule icon.
7. Verify a modal to select Date and time appears.
8. Select a Future date and click on `Schedule` button.
9. Verify the message is not seen under Drafts tab.
10. Goto Scheduled tab.
10. Go to Scheduled tab.
11. Verify the Scheduled message appears on the top.
12. GOto the DM/GM/Channel where the draft was created.
12. Go to the DM/GM/Channel where the draft was created.
13. Verify the message post is not typed in the text box.
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
---
# (Required) Ensure all values are filled up
name: "Verify User can remove scheduled setting from the Scheduled message"
name: "Verify User can remove scheduled setting from a scheduled message"
status: Active
priority: Normal
folder: Schedule Messages
authors: "@yasserfaraazkhan"
team_ownership:
- ICU
priority_p1_to_p4: P2 - Core Functions (Do core functions work?)
priority_p1_to_p4: P3 - Deep Functions (Do extensive scenarios work?)

# (Optional)
location: null
Expand Down Expand Up @@ -40,14 +40,14 @@ steps_hashed: null
Steps:

1. Log into User's account.
2. Goto Scheduled tab.
2. Go to Scheduled tab.
3. Verify the Draft is created and has channel name and date of creation.
4. Hover on the Draft.
5. Click on the Schedule icon.
6. Verify a modal to select Date and time appears.
7. Select a Future date and click on `Schedule` button.
8. Verify the message is not seen under Drafts tab.
9. Goto Scheduled tab.
9. Go to Scheduled tab.
10. Verify the Scheduled message appears on the top.
11. GOto the DM/GM/Channel where the draft was created.
11. Go to the DM/GM/Channel where the draft was created.
12. Verify the message post is not typed in the text box.

0 comments on commit 4d11176

Please sign in to comment.