Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor(dal): Deprecate l1_batches.l2_to_l1_logs (#2175)
**review notes**: - changes in `core/lib/types/src/commitment/tests/**.json`s - only formatting. - as a follow-up to this PR there should be another PR that adds drop `l1_batches.l2_to_l1_logs` column migration. ## What ❔ - New dal method `get_l2_to_l1_logs_by_number` that fetches logs for a specific number from `l2_to_l1_logs` table. - More complicated way to construct `L1BatchHeader`. Now we fetch data from the `l1_batches` table as `StorageL1BatchHeader `..then fetch l2l1 logs using `get_l2_to_l1_logs_by_number` and after, use the helper `into_l1_batch_header_with_logs ` method to construct `L1BatchHeader`. ## Why ❔ The main motivation for this change is to avoid keeping info about l2l1 logs in 2 tables. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zk fmt` and `zk lint`. - [ ] Spellcheck has been run via `zk spellcheck`.
- Loading branch information