Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add eigenda steps to run #271

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

gianbelinche
Copy link

Description

This PR adds documentation needed for EigenDA integration.

Linked Issues

matter-labs/zksync-era#3243 (comment)

@gianbelinche gianbelinche requested a review from a team as a code owner November 26, 2024 15:03
@popzxc
Copy link
Member

popzxc commented Nov 27, 2024

@dimazhornyk ptal

Copy link
Collaborator

@dimazhornyk dimazhornyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments, but let's get back to the doc when we have your PR merged, so the docs don't represent the future state


Changes needed both for local and mainnet/testnet setup.

1. Add `da_client` to `etc/env/file_based/general.yaml`:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about etc/env/file_based as those are the base for all the chains, I'd prefer we use a generic pattern to point to the specific chain config

```

2. Add the following block to the `secrets.yaml`:
2. Also set the private key in `etc/env/file_based/secrets.yaml`:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here


```yaml
da:
eigen:
private_key: YOUR_PRIVATE_KEY
```

3. (optional) for using pubdata with 2MiB (as per specification), modify `etc/env/file_based/general.yaml`:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

3. (optional) for using pubdata with 2MiB (as per specification), modify `etc/env/file_based/general.yaml`:

```yaml
max_pubdata_per_batch: 2097152
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we actually have a limit of 761856 enforced in the system contracts
it should be removed soon, but still, let's not confuse the readers here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants