Skip to content

Commit

Permalink
chore: add concurrency rules to workflows (#102)
Browse files Browse the repository at this point in the history
# Description

Add concurrency rules to workflows for staging and production deploy
workflows. This cancels any currently running workflow when a new
workflow is set to run. For example when two PRs are merged to main
around the same time, one will cancel out the other and only one
workflow is run to deploy.
This makes it so that we don't have a queue of build and deploys to run,
cutting down time and resources.

Fix yaml formatting errors with github issue templates. They do not list
in Create Issues if format is incorrect.
  • Loading branch information
itsacoyote authored Jun 4, 2024
1 parent 1312751 commit 26c9d06
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ name: Bug Report
description: File a bug report.
title: "[Bug]: "
labels: ["bug", "triage"]
assignees:
- matter-labs/devxp
body:
- type: markdown
attributes:
Expand All @@ -13,15 +15,13 @@ body:
label: What happened?
description: Also tell us, what did you expect to happen?
placeholder: Tell us what you see!
value: ""
validations:
required: true
- type: textarea
id: expected
attributes:
label: What did you expect to happen?
placeholder: Tell us what you expected!
value: ""
- type: textarea
id: environment
attributes:
Expand Down
4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/feature_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ name: Feature Request
description: Is there a feature missing you would like to see? Let us know!
title: "[Feature]: "
labels: ["feature", "triage"]
assignees:
- matter-labs/devxp
body:
- type: markdown
attributes:
Expand All @@ -13,14 +15,12 @@ body:
label: Description
description: Please provide a brief description of the feature you would like to see.
placeholder: Tell us what you would like to see!
value: ""
- type: textarea
id: rationale
attributes:
label: Rationale
description: Why do you think this feature would be beneficial to the project?
placeholder: Tell us why you think this feature would be beneficial!
value: ""
- type: checkboxes
id: terms
attributes:
Expand Down
4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/feedback.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ name: Feedback
description: Please share any feedback for us on our content!
title: "[Feedback]: "
labels: ["feedback", "triage"]
assignees:
- matter-labs/devxp
body:
- type: markdown
attributes:
Expand All @@ -13,14 +15,12 @@ body:
label: Page
description: If this is related to a specific page, please provide the URL.
placeholder: https://docs.zksync.io/page
value: ""
- type: textarea
id: description
attributes:
label: Description
description: Please provide a brief description of the feedback you would like to share.
placeholder: Tell us what you would like to share!
value: ""
- type: checkboxes
id: terms
attributes:
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/deploy-prod.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ env:
HUSKY: 0
CI: true

concurrency:
group: production
cancel-in-progress: true

jobs:
build_and_deploy:
env:
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/deploy-staging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ env:
HUSKY: 0
CI: true

concurrency:
group: staging
cancel-in-progress: true

jobs:
build_and_deploy:
env:
Expand Down

0 comments on commit 26c9d06

Please sign in to comment.