Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get rid of redundant dependencies #69

Merged
merged 2 commits into from
Oct 12, 2023
Merged

fix: get rid of redundant dependencies #69

merged 2 commits into from
Oct 12, 2023

Conversation

JackHamer09
Copy link
Member

@JackHamer09 JackHamer09 commented Oct 12, 2023 •
edited
Loading

What 💻

  • Uninstall @rudderstack/rudder-sdk-node package
  • Remove analytics
  • Uninstall ofetch package, replaced with built-in node.js fetch

Why ✋

  • RudderStack SDK package was causing dependency issues when installing CLI globally with npm i -g zksync-cli because of incorrectly included dependency in SDK's package
  • Analytics removed until a better analytics tool is found
  • Replace ofetch with built-in node.js fetch to reduce package size

@JackHamer09 JackHamer09 requested a review from a team as a code owner October 12, 2023 12:14
MexicanAce
MexicanAce approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@MexicanAce MexicanAce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JackHamer09 JackHamer09 merged commit c1b13d9 into main Oct 12, 2023
2 checks passed
@JackHamer09 JackHamer09 deleted the uninstall-redundant-dependencies branch October 12, 2023 12:33
@github-actions
Copy link

🎉 This PR is included in version 0.6.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 0.7.0-alpha.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

@JackHamer09 JackHamer09 mentioned this pull request Oct 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MexicanAce MexicanAce MexicanAce approved these changes

Assignees
No one assigned
Labels
released on @alpha released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JackHamer09 @MexicanAce