Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create project works on all systems, properly remove git folder #67

Merged
merged 1 commit into from
Oct 12, 2023
Merged

fix: create project works on all systems, properly remove git folder #67

merged 1 commit into from
Oct 12, 2023

Conversation

JackHamer09
Copy link
Member

@JackHamer09 JackHamer09 commented Oct 11, 2023 •
edited
Loading

What 💻

create project command improvements and fixes:

  • Replaced running raw unix commands like cd or rm with node.js native methods (from fs package)
  • Properly handle the case when folder already exists
  • Check for yarn installation, before running yarn scripts
  • Improved text and colors for all project create logs

Why ✋

  • To improve cross-platform compatibility
  • To prevent potential errors or overwriting during project creation
  • To ensure successful script execution without dependency failures
  • To enhance user experience with clearer and visually appealing logs

Evidence 📷

image

@JackHamer09 JackHamer09 requested a review from a team as a code owner October 11, 2023 13:48
MexicanAce
MexicanAce approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@MexicanAce MexicanAce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JackHamer09 JackHamer09 merged commit a212f05 into main Oct 12, 2023
2 checks passed
@JackHamer09 JackHamer09 deleted the dr-devrl-317-ubuntuwindows-error-message-is-present-for-create-project branch October 12, 2023 10:01
@github-actions
Copy link

🎉 This PR is included in version 0.6.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 0.7.0-alpha.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

@JackHamer09 JackHamer09 mentioned this pull request Oct 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MexicanAce MexicanAce MexicanAce approved these changes

Assignees
No one assigned
Labels
released on @alpha released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JackHamer09 @MexicanAce