fix: sanitize yul artifact contract names #819
Merged
+25
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popzxc
previously approved these changes
Jan 8, 2025
nbaztec
reviewed
Jan 9, 2025
nbaztec
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
Sanitize contract output for yul source files so that a raw file name is used instead of the whole path.
Why ✋
Given matter-labs/era-compiler-solidity#243, the source name path is used instead of the contract name as the field that contains compilation output of contracts in yul files. This breaks foundry assumptions and makes for weird behavior when storing files.
Evidence 📷
Yul compilation test changed to look for the file name without the extension. Artifact that previously was created after running the test gets removed by temp project.