Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch to stable compiler #814

Merged
merged 9 commits into from
Jan 9, 2025
Merged

feat: switch to stable compiler #814

merged 9 commits into from
Jan 9, 2025

Conversation

popzxc
Copy link
Member

@popzxc popzxc commented Jan 7, 2025

Ports to stable rust.

⚠️ With this PR we no longer compile era-test-node and spawn it in a separate thread; instead we invoke anvil-zksync via alloy-zksync, so the binary must be installed locally to run tests.

@popzxc popzxc marked this pull request as ready for review January 7, 2025 12:26
@popzxc popzxc requested a review from a team as a code owner January 7, 2025 12:26
@popzxc popzxc force-pushed the popzxc-stable branch 3 times, most recently from cc5ecb6 to b94d075 Compare January 7, 2025 13:25
@nbaztec
Copy link
Collaborator

nbaztec commented Jan 8, 2025

Given that the era-test-node server was being run in-memory and compiled under dev, and that we're still using other crates of anvil-zksync, I believe we're just slowing down the tests by forking processes during development.
Is there a major speedup that comes with this PR?

@popzxc
Copy link
Member Author

popzxc commented Jan 8, 2025

Huh, I didn't expect the test execution time to go 2x. That's unfortunate.
Compiling becomes somewhat faster (since a lot of deps were removed), but not sure if it warrants increased execution time.

I guess then it makes sense to keep using compiled-in version of anvil-zksync.
@dutterbutter maybe we can combine this pr with #810?

@dutterbutter
Copy link
Collaborator

@popzxc sounds good. I can re-open #810 and have it ready for review.

@popzxc popzxc requested a review from nbaztec January 9, 2025 07:04
@popzxc
Copy link
Member Author

popzxc commented Jan 9, 2025

@nbaztec now anvil-zksync is spawned in-memory, the test run time decreased accordingly.

.github/workflows/nextest.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
Copy link
Collaborator

@nbaztec nbaztec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @popzxc 🎉

@popzxc popzxc merged commit 36db986 into main Jan 9, 2025
23 checks passed
@popzxc popzxc deleted the popzxc-stable branch January 9, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants