Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get rid of zksync_select_fork_vm method #813

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Conversation

popzxc
Copy link
Member

@popzxc popzxc commented Jan 7, 2025

What 💻

Removes zksync_select_fork_vm from cheatcode strategy.
This is done majorly by changing the logic of execution:

  • For select_fork: we add account to persisted accounts, select VM, and then execute as usual.
  • For create_select_fork: we execute createFork cheatcode, then select VM, then execute selectFork cheatcode. Basically, we split the operation into two and do VM selection in between.

Why ✋

With that, there will be no ZKsync-specific logic in cheatcode implementations.

@popzxc popzxc marked this pull request as ready for review January 8, 2025 06:09
@popzxc popzxc requested a review from a team as a code owner January 8, 2025 06:09
@popzxc popzxc merged commit e85875e into main Jan 8, 2025
23 checks passed
@popzxc popzxc deleted the popzxc-select-fork branch January 8, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants