feat: get rid of zksync_select_fork_vm method #813
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
Removes
zksync_select_fork_vm
from cheatcode strategy.This is done majorly by changing the logic of execution:
select_fork
: we add account to persisted accounts, select VM, and then execute as usual.create_select_fork
: we executecreateFork
cheatcode, then select VM, then executeselectFork
cheatcode. Basically, we split the operation into two and do VM selection in between.Why ✋
With that, there will be no ZKsync-specific logic in cheatcode implementations.