-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Initial support for custom paymaster #591
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karrq
requested changes
Sep 25, 2024
…d simplify imports
elfedy
approved these changes
Sep 25, 2024
elfedy
previously approved these changes
Sep 25, 2024
elfedy
approved these changes
Sep 26, 2024
Karrq
approved these changes
Sep 26, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We're enhancing our ZKSync specific capabilities by implementing paymaster functionality. This allows for sponsored transactions, improving user experience by enabling third parties to cover gas fees on behalf of users. More info about paymaster here as well as some examples.
Solution
zkUsePaymaster
Cheatcodes
inspector struct withpaymaster_params
CheatcodeTracerContext
to include paymaster dataTesting Approach
Paymaster.t.sol
:testCallWithPaymaster
: Verifies paymaster usage in function callstestCreateWithPaymaster
: Tests paymaster usage in contract creationtestFailPaymasterBalanceDoesNotUpdate
: Highlights an issue with observing paymaster balance changesNote
Extra: We are depending on a third party dependency until this issue is resolved.