Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: N-04 Unsafe ABI Encoding #989

Draft
wants to merge 266 commits into
base: oz-audit-sep-base
Choose a base branch
from
Draft

fix: N-04 Unsafe ABI Encoding #989

wants to merge 266 commits into from

Conversation

kelemeno
Copy link
Contributor

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

StanislavBreadless and others added 30 commits August 13, 2024 19:50
@StanislavBreadless
fix spell
b4b7c03
@StanislavBreadless
Merge pull request #692 from matter-labs/sb-set-of-fixes-1
4c4411c 
Set of fixes from gateway
@StanislavBreadless
amend some functions
2a2e6cf
@StanislavBreadless
make scripts work
9f6d439
@StanislavBreadless
fmt
576a59c
@StanislavBreadless
fix lint
779c707
@StanislavBreadless
Merge pull request #697 from matter-labs/sb-synced-sync-layer-reorg
8534b30 
Port some commits from kl/sync-layer-reorg
@kelemeno @StanislavBreadless
Kl/l2 bridge fixes (#687)
50c633c 
Co-authored-by: Stanislav Bezkorovainyi <[email protected]>
@kelemeno
Merge branch 'kl/sync-layer-reorg' of ssh://github.com/matter-labs/er…
4fec3c1 
…a-contracts into kl/sync-layer-reorg
@benceharomi
fix: zksync-ethers v5 dependency (#702)
fd4aebc
@kelemeno
Kl/stmdt counterpart fix EVM-701 (#693)
f1a8c2d
@kelemeno
fix: move hyperchain mapping EVM-709 (#704)
df1c5c8
@kelemeno
bridgehub small fixes, some cleanup
acd603a
@kelemeno
Merge branch 'kl/sync-layer-reorg' of ssh://github.com/matter-labs/er…
ad92d47 
…a-contracts into kl/migrate-back-from-gw
@kelemeno
fix: EVM-708 bridge fixes (#703)
7d4b79c
@StanislavBreadless
Limitations for the l2 migrated chain (#707)
4c82e7d
@kelemeno
small fixes
6d0ceb9
@kelemeno
Merge branch 'kl/sync-layer-reorg' of ssh://github.com/matter-labs/er…
a738dc8 
…a-contracts into kl/migrate-back-from-gw
@kelemeno
more fixes
c168183
@kelemeno
typo
a9a4646
@kelemeno
Stas issues
ff10238
@StanislavBreadless
removed unsued function + some changes
d4bb8c5
@kelemeno
fixes
2a22e23
@StanislavBreadless
fix some legacy methods
590d207
@StanislavBreadless
fmt
83cd458
@StanislavBreadless
additional changes
42e7e0a
@StanislavBreadless
fmt
aff1f4e
@StanislavBreadless
commented out code
8099c0e
@StanislavBreadless
lint fix
ce27e0b
@StanislavBreadless
should work
ec64d85
StanislavBreadless and others added 27 commits September 6, 2024 13:44
@StanislavBreadless
lint
ef33539
@StanislavBreadless
Remove most info from relayed L1->GW priority ops (#775)
dccc114
@StanislavBreadless
Merge pull request #778 from matter-labs/sb-merge-main-to-dev
b653ac8 
Merge main to dev
@StanislavBreadless
sync with reorg
cb3c177
@StanislavBreadless
fmt
23f5e3c
@StanislavBreadless
Merge pull request #779 from matter-labs/sb-sync-reorg-with-stable
cb42ae4 
Sync reorg with stable
@vladbochok
Change Executor.sol interface (#780)
49868af
@Raid5594 @StanislavBreadless
(feat): add tx filterer contract (#772)
bebdefc 
Co-authored-by: Raid Ateir <[email protected]>
Co-authored-by: Stanislav Breadless <[email protected]>
@Raid5594 @kelemeno
@StanislavBreadless @vladbochok
Ra/split asset router (#595)
f95beef 
Co-authored-by: Raid Ateir <[email protected]>
Co-authored-by: kelemeno <[email protected]>
Co-authored-by: kelemeno <[email protected]>
Co-authored-by: Stanislav Bezkorovainyi <[email protected]>
Co-authored-by: Vlad Bochok <[email protected]>
@kelemeno
chore: merge stable (#785)
8479868
@kelemeno @vladbochok
Update l1-contracts/contracts/bridge/L1Nullifier.sol
d1b7e16 
Co-authored-by: Vlad Bochok <[email protected]>
@kelemeno @vladbochok
Update l1-contracts/contracts/bridge/asset-router/IL1AssetRouter.sol
e741471 
Co-authored-by: Vlad Bochok <[email protected]>
@kelemeno
fix: vlad issues (#788)
a42b991
@StanislavBreadless
Recover some tests (#789)
2508f36
@kelemeno @StanislavBreadless
Kl/chain balance fix (#786)
b3564ef 
Co-authored-by: Raid Ateir <[email protected]>
Co-authored-by: Stanislav Bezkorovainyi <[email protected]>
@kelemeno
Merge branch 'dev' of ssh://github.com/matter-labs/era-contracts into…
1404dc0 
… kl/sync-layer-reorg
@kelemeno @Deniallugo @vladbochok
chore: merge main (#790)
cc3b2ac 
Signed-off-by: Danil <[email protected]>
Co-authored-by: Danil <[email protected]>
Co-authored-by: Vlad Bochok <[email protected]>
@kelemeno
Merge branch 'dev' of ssh://github.com/matter-labs/era-contracts into…
8155711 
… kl/merge-dev
@kelemeno
test fixes
c0d45fa
@StanislavBreadless
Merge pull request #791 from matter-labs/kl/merge-dev
6de2963 
chore: Kl/merge-dev
@vladbochok
Fixes (#792)
07d0462
@StanislavBreadless
sync head with base
1673186
@StanislavBreadless
delete unneeded files
eb3583a
@StanislavBreadless
Sync audit head with base (#797)
e5727a0
@StanislavBreadless
Merge pull request #798 from matter-labs/sb-sync-head-base
ef318e2 
Sync head with base
@StanislavBreadless
Better governance protection (audit) (#822)
8208402
@kelemeno
fix: N-04 Unsafe ABI Encoding
780b027
Base automatically changed from library-fix-review to oz-audit-sep-base December 17, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladbochok vladbochok vladbochok approved these changes

@Deniallugo Deniallugo Awaiting requested review from Deniallugo Deniallugo will be requested when the pull request is marked ready for review Deniallugo is a code owner

@StanislavBreadless StanislavBreadless Awaiting requested review from StanislavBreadless StanislavBreadless will be requested when the pull request is marked ready for review StanislavBreadless is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.