chore(l1-contracts): Migrate L1 Contracts to Custom Errors

.codespell/wordlist.txt

@@ -4,3 +4,4 @@ ue
 tha
 bu
 crate
+DNE

_typos.toml

@@ -5,6 +5,7 @@ extend-exclude = [
     "/l1-contracts/out/",
     "/l1-contracts/node_modules/",
     "/l1-contracts/artifacts",
+    "/l1-contracts-foundry/lib/",
     "/l2-contracts/artifacts-zk",
     "/l2-contracts/cache-zk",
     "/l2-contracts/typechain",
@@ -22,3 +23,4 @@ extend-exclude = [
 # Don't correct the surname "Teh"
 FOT = "FOT"
 ue = "ue"
+DNE = "DNE"

l1-contracts/contracts/bridge/L1ERC20Bridge.sol

@@ -2,8 +2,6 @@
 
 pragma solidity 0.8.24;
 
-// solhint-disable gas-custom-errors
-
 import {IERC20} from "@openzeppelin/contracts-v4/token/ERC20/IERC20.sol";
 import {SafeERC20} from "@openzeppelin/contracts-v4/token/ERC20/utils/SafeERC20.sol";
 
@@ -13,6 +11,8 @@ import {IL1SharedBridge} from "./interfaces/IL1SharedBridge.sol";
 import {L2ContractHelper} from "../common/libraries/L2ContractHelper.sol";
 import {ReentrancyGuard} from "../common/ReentrancyGuard.sol";
 
+import {Unauthorized, EmptyDeposit, ValueMismatch, WithdrawalAlreadyFinalized} from "../common/L1ContractErrors.sol";
+
 /// @author Matter Labs
 /// @custom:security-contact [email protected]
 /// @notice Smart contract that allows depositing ERC20 tokens from Ethereum to hyperchains
@@ -67,7 +67,9 @@ contract L1ERC20Bridge is IL1ERC20Bridge, ReentrancyGuard {
 
     /// @dev transfer token to shared bridge as part of upgrade
     function transferTokenToSharedBridge(address _token) external {
-        require(msg.sender == address(SHARED_BRIDGE), "Not shared bridge");
+        if (msg.sender != address(SHARED_BRIDGE)) {
+            revert Unauthorized(msg.sender);
+        }
         uint256 amount = IERC20(_token).balanceOf(address(this));
         IERC20(_token).safeTransfer(address(SHARED_BRIDGE), amount);
     }
@@ -150,9 +152,15 @@ contract L1ERC20Bridge is IL1ERC20Bridge, ReentrancyGuard {
         uint256 _l2TxGasPerPubdataByte,
         address _refundRecipient
     ) public payable nonReentrant returns (bytes32 l2TxHash) {
-        require(_amount != 0, "0T"); // empty deposit
+        // empty deposit
+        if (_amount == 0) {
+            revert EmptyDeposit();
+        }
         uint256 amount = _depositFundsToSharedBridge(msg.sender, IERC20(_l1Token), _amount);
-        require(amount == _amount, "3T"); // The token has non-standard transfer logic
+        // The token has non-standard transfer logic
+        if (amount != _amount) {
+            revert ValueMismatch(_amount, amount);
+        }
 
         l2TxHash = SHARED_BRIDGE.depositLegacyErc20Bridge{value: msg.value}({
             _msgSender: msg.sender,
@@ -196,7 +204,10 @@ contract L1ERC20Bridge is IL1ERC20Bridge, ReentrancyGuard {
         bytes32[] calldata _merkleProof
     ) external nonReentrant {
         uint256 amount = depositAmount[_depositSender][_l1Token][_l2TxHash];
-        require(amount != 0, "2T"); // empty deposit
+        // empty deposit
+        if (amount == 0) {
+            revert EmptyDeposit();
+        }
         delete depositAmount[_depositSender][_l1Token][_l2TxHash];
 
         SHARED_BRIDGE.claimFailedDepositLegacyErc20Bridge({
@@ -225,7 +236,9 @@ contract L1ERC20Bridge is IL1ERC20Bridge, ReentrancyGuard {
         bytes calldata _message,
         bytes32[] calldata _merkleProof
     ) external nonReentrant {
-        require(!isWithdrawalFinalized[_l2BatchNumber][_l2MessageIndex], "pw");
+        if (isWithdrawalFinalized[_l2BatchNumber][_l2MessageIndex]) {
+            revert WithdrawalAlreadyFinalized();
+        }
         // We don't need to set finalizeWithdrawal here, as we set it in the shared bridge
 
         (address l1Receiver, address l1Token, uint256 amount) = SHARED_BRIDGE.finalizeWithdrawalLegacyErc20Bridge({