-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synclayer Batch Aggregation #470
Open
vladenysiuk
wants to merge
18
commits into
dev
Choose a base branch
from
synclayer-batch-aggregation
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 14 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
d5abac7
basic batchaggregator
vladenysiuk 120387d
fix build
vladenysiuk 1255a76
bug fixed + pubdata parsing
vladenysiuk e4317d1
fix lint
vladenysiuk 0d760f7
implement stateDiff compression
vladenysiuk 84ab8eb
Revert "implement stateDiff compression"
vladenysiuk 38e82b4
compress uncompressed state diffs
vladenysiuk 1fc16b0
add compressed state diffs
vladenysiuk 150eb61
aggregate uncompressed statediffs
vladenysiuk 31969ae
optimal statediff compression
vladenysiuk 07b1416
change uncompressed data + fix minor issues
vladenysiuk cf1317f
unchecked math + type().max
vladenysiuk 41ca248
fix messages compression
vladenysiuk 3604c6b
handle compressedData size = 32
vladenysiuk a79d428
aggregate initial and repeated writes
vladenysiuk f4daf1d
fix warnings
vladenysiuk 68f6074
increase stateDiff readability
vladenysiuk a28a65d
merge hyperchain and statediff hash
vladenysiuk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
12 changes: 12 additions & 0 deletions
12
l1-contracts/contracts/common/interfaces/IBatchAggregator.sol
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
// SPDX-License-Identifier: MIT | ||
|
||
pragma solidity 0.8.24; | ||
|
||
interface IBatchAggregator { | ||
function commitBatch( | ||
bytes calldata _totalL2ToL1PubdataAndStateDiffs, | ||
uint256 chainId, | ||
uint256 batchNumber | ||
) external; | ||
function returnBatchesAndClearState() external returns (bytes memory); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need to send both compressed diffs and their uncompressed version? I think we should decide on what we want. I would rather send only uncompressed ones