-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(): v0 shared bridge #29
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benceharomi
requested review from
vladbochok and
StanislavBreadless
as code owners
September 26, 2023 18:09
4 tasks
benceharomi
force-pushed
the
kl-factory
branch
3 times, most recently
from
October 4, 2023 14:51
3478fa9
to
87f53ee
Compare
4 tasks
benceharomi
force-pushed
the
kl-factory
branch
from
October 4, 2023 15:17
87f53ee
to
382ac30
Compare
vladbochok
reviewed
Oct 23, 2023
ethereum/contracts/bridgehub/bridgehub-deps/BridgehubMailbox.sol
Outdated
Show resolved
Hide resolved
ethereum/contracts/state-transition/chain-deps/StateTransitionChainStorage.sol
Outdated
Show resolved
Hide resolved
ethereum/contracts/state-transition/chain-deps/facets/Admin.sol
Outdated
Show resolved
Hide resolved
ethereum/contracts/state-transition/chain-deps/facets/Admin.sol
Outdated
Show resolved
Hide resolved
ethereum/contracts/state-transition/chain-deps/facets/Mailbox.sol
Outdated
Show resolved
Hide resolved
ethereum/contracts/state-transition/chain-deps/facets/Mailbox.sol
Outdated
Show resolved
Hide resolved
ly0va
reviewed
Jan 4, 2024
benceharomi
reviewed
Jan 5, 2024
benceharomi
reviewed
Jan 5, 2024
vladbochok
reviewed
Jan 5, 2024
l1-contracts/contracts/bridgehub/bridgehub-interfaces/IBridgehub.sol
Outdated
Show resolved
Hide resolved
l1-contracts/contracts/state-transition/chain-deps/facets/Base.sol
Outdated
Show resolved
Hide resolved
l1-contracts/contracts/state-transition/ZkSyncStateTransition.sol
Outdated
Show resolved
Hide resolved
l1-contracts/contracts/state-transition/ZkSyncStateTransition.sol
Outdated
Show resolved
Hide resolved
l1-contracts/contracts/state-transition/ZkSyncStateTransition.sol
Outdated
Show resolved
Hide resolved
benceharomi
reviewed
Jan 5, 2024
vladbochok
reviewed
Jan 9, 2024
l1-contracts/contracts/dev-contracts/test/ExecutorProvingTest.sol
Outdated
Show resolved
Hide resolved
l1-contracts/contracts/state-transition/chain-interfaces/IStateTransitionChain.sol
Outdated
Show resolved
Hide resolved
l1-contracts/contracts/state-transition/ZkSyncStateTransition.sol
Outdated
Show resolved
Hide resolved
vladbochok
reviewed
Jan 11, 2024
l1-contracts/contracts/state-transition/chain-deps/facets/Mailbox.sol
Outdated
Show resolved
Hide resolved
vladbochok
reviewed
Jan 11, 2024
fixed tests
Co-authored-by: kelemeno <[email protected]> Co-authored-by: Vlad Bochok <[email protected]> Co-authored-by: vladbochok <[email protected]>
Feat validium mode dev kalman
StanislavBreadless
approved these changes
Mar 7, 2024
0xVolosnikov
pushed a commit
that referenced
this pull request
Sep 17, 2024
* Remove invalid todos adding overflow checks * Remove old memory check * Add preprocessed evm interpreter * Remove unnecesary memory checks * Update hash for evm interpreter
koloz193
pushed a commit
that referenced
this pull request
Dec 11, 2024
feat: update foundry, replace --zk-avoid-contracts with --skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v0 shared bridge
Split mailbox from rest of the facets.
Added factory contracts that deploy the contracts for specific chains.
Moved from diamond to tupp.
Modified necessary scripts.
Checklist
zk fmt
andzk lint
.