Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docstrings): added doc string comments where missing #189

Merged
merged 3 commits into from
Feb 2, 2024
Merged

chore(docstrings): added doc string comments where missing #189

merged 3 commits into from
Feb 2, 2024

Conversation

koloz193
Copy link
Contributor

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

StanislavBreadless
StanislavBreadless reviewed Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@StanislavBreadless StanislavBreadless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lacking comment for sendL2ToL1Log

l1-contracts/contracts/zksync/interfaces/IExecutor.sol Outdated Show resolved Hide resolved
l1-contracts/contracts/zksync/interfaces/IExecutor.sol Outdated Show resolved Hide resolved
l1-contracts/contracts/zksync/interfaces/IExecutor.sol Outdated Show resolved Hide resolved
system-contracts/contracts/L1Messenger.sol Outdated Show resolved Hide resolved
@koloz193 koloz193 merged commit 05dc432 into zk-4844 Feb 2, 2024
16 of 17 checks passed
@koloz193 koloz193 deleted the zk-evm-444-n-09-missing-docstrings branch February 2, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StanislavBreadless StanislavBreadless StanislavBreadless approved these changes

@vladbochok vladbochok Awaiting requested review from vladbochok vladbochok is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koloz193 @StanislavBreadless