Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: outdated link to foundry config docs #113

Closed
wants to merge 0 commits into from

Conversation

krauspt
Copy link
Contributor

@krauspt krauspt commented Dec 16, 2023

What ❔

I've found an outdated link pointing to oundry config documentation. This PR replaces the outdated link with a working link.

Why ❔

To keep external resources approachable.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Documentation comments have been added / updated.

@krauspt
Copy link
Contributor Author

krauspt commented Dec 21, 2023

@vladbochok @StanislavBreadless is there anything from my side that needs to be done?

@StanislavBreadless
Copy link
Collaborator

@krauspt Hey, we are sorry for the long wait. Could you please resolve the conflicts? (Basically replicate your change into the following file: https://github.com/matter-labs/era-contracts/blob/main/l1-contracts/foundry.toml)

@krauspt
Copy link
Contributor Author

krauspt commented Jan 16, 2024

@StanislavBreadless sorry, I wasn't able to do it within this PR. I opened #172. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants