chore: the errors in the document have been corrected #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penghuarong
requested review from
vladbochok and
StanislavBreadless
as code owners
| @@ -17,7 +17,7 @@ import "./interfaces/IL2StandardToken.sol"; | |||
| /// - It implements `permit` method to allow users to sign a message instead of calling `approve`. | |||
| /// | |||
| /// Note: This is an upgradeable contract. In the future, we will remove upgradeability to make it trustless. | |||
| /// But for now, when the Rollup has instant upgradability, we leave the possibility of upgrading to improve the contract if needed. | |||
| /// But for now, when the Rollup has instant upgradeability, we leave the possibility of upgrading to improve the contract if needed. | |||
There was a problem hiding this comment.
https://thecontentauthority.com/blog/upgradable-vs-upgradeable
Hey! I am not sure this is a typo, since upgradable (and "upgradability") seem more correct in this context
|
Also, it is a duplicate of: https://github.com/matter-labs/era-contracts/pull/105/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Checklist