fix(executor): separated require with 2 conditions into 2 statements (#…

…179)
matter-labs · Feb 2, 2024 · bd09d4f · bd09d4f
1 parent 91b48f9
commit bd09d4f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/l1-contracts/contracts/zksync/facets/Executor.sol b/l1-contracts/contracts/zksync/facets/Executor.sol
@@ -518,11 +518,8 @@ contract ExecutorFacet is Base, IExecutor {
         uint256 versionedHashIndex = 0;
 
         require(_pubdataCommitments.length > 0, "pl");
-        require(
-            _pubdataCommitments.length <= PUBDATA_COMMITMENT_SIZE * MAX_NUMBER_OF_BLOBS &&
-                _pubdataCommitments.length % PUBDATA_COMMITMENT_SIZE == 0,
-            "bs"
-        );
+        require(_pubdataCommitments.length <= PUBDATA_COMMITMENT_SIZE * MAX_NUMBER_OF_BLOBS, "bd");
+        require(_pubdataCommitments.length % PUBDATA_COMMITMENT_SIZE == 0, "bs");
         blobCommitments = new bytes32[](MAX_NUMBER_OF_BLOBS);
 
         for (uint256 i = 0; i < _pubdataCommitments.length; i += PUBDATA_COMMITMENT_SIZE) {

diff --git a/l1-contracts/test/foundry/unit/concrete/Executor/Committing.t.sol b/l1-contracts/test/foundry/unit/concrete/Executor/Committing.t.sol
@@ -552,7 +552,7 @@ contract CommittingTest is ExecutorTest {
 
         vm.prank(validator);
 
-        vm.expectRevert(bytes("bs"));
+        vm.expectRevert(bytes("bd"));
         executor.commitBatches(genesisStoredBatchInfo, correctCommitBatchInfoArray);
     }