L1 contracts CI

update todos fix efficient calls #2143

Sign in to view logs

Triggered via pull request June 24, 2024 19:52

koloz193

synchronize #549

zk-custom-da-testing

Status Failure

Total duration 1m 28s

Artifacts –

l1-contracts-ci.yaml

on: pull_request

check-verifier-generator

Annotations

5 errors and 6 warnings

check-verifier-generator

No url found for submodule path 'l1-contracts/lib/openzeppelin-contracts-upgradeable-v4' in .gitmodules

check-verifier-generator

The process '/usr/bin/git' failed with exit code 128

lint: l1-contracts/contracts/bridgehub/MessageRoot.sol#L126

GC: For [ i ] variable, increment/decrement by 1 using: [ ++variable ] to save gas

lint: l1-contracts/contracts/state-transition/data-availability/ValidiumL1DAValidator.sol#L7

imported name PubdataSource is not used

Process completed with exit code 1.

check-verifier-generator

The process '/usr/bin/git' failed with exit code 128

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

lint: l1-contracts/contracts/state-transition/chain-deps/facets/Mailbox.sol#L310

Avoid to use tx.origin

The process '/usr/bin/git' failed with exit code 128

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, actions/cache/save@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The process '/usr/bin/git' failed with exit code 128