Skip to content
System contracts CI

update todos fix efficient calls #2136

Sign in to view logs

update todos fix efficient calls

update todos fix efficient calls #2136

Triggered via pull request June 24, 2024 18:30
@koloz193koloz193
synchronize #549
zk-custom-da-testing
Status Failure
Total duration 2m 20s
Artifacts –

system-contracts-ci.yaml

on: pull_request
build
1m 28s
build
lint
40s
lint
check-hashes
27s
check-hashes
test-bootloader
0s
test-bootloader
test-contracts
0s
test-contracts
Fit to window
Zoom out
Zoom in

Annotations

11 errors and 6 warnings
lint: l1-contracts/contracts/state-transition/chain-deps/facets/Executor.sol#L8
imported name POINT_EVALUATION_PRECOMPILE_ADDR is not used
lint: l1-contracts/contracts/state-transition/chain-deps/facets/Executor.sol#L13
imported name L2_PUBDATA_CHUNK_PUBLISHER_ADDR is not used
lint: l1-contracts/contracts/state-transition/chain-deps/facets/Executor.sol#L14
imported name PubdataPricingMode is not used
lint: l1-contracts/contracts/state-transition/data-availability/RollupL1DAValidator.sol#L128
GC: For [ i ] variable, increment/decrement by 1 using: [ ++variable ] to save gas
lint: l1-contracts/contracts/state-transition/data-availability/RollupL1DAValidator.sol#L185
GC: For [ i ] variable, increment/decrement by 1 using: [ ++variable ] to save gas
lint: l1-contracts/contracts/state-transition/data-availability/ValidiumL1DAValidator.sol#L7
imported name PubdataSource is not used
lint: l1-contracts/contracts/state-transition/data-availability/ValidiumL1DAValidator.sol#L10
GC: [operatorDAInput] argument on Function [checkDA] could be [calldata] if it's not being updated
lint: l2-contracts/contracts/data-availability/RollupL2DAValidator.sol#L30
Named parameters missing. MIN unnamed argumenst is 4
lint: l2-contracts/contracts/data-availability/StateDiffL2DAValidator.sol#L7
imported name IL2DAValidator is not used
lint: l2-contracts/contracts/data-availability/ValidiumL2DAValidator.sol#L9
imported name PUBDATA_CHUNK_PUBLISHER is not used
check-hashes
Process completed with exit code 1.
lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
lint
The process '/usr/bin/git' failed with exit code 128
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, actions/cache/save@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
build
The process '/usr/bin/git' failed with exit code 128
check-hashes
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, actions/cache/restore@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
check-hashes
The process '/usr/bin/git' failed with exit code 128