Skip to content

feat(contracts): Merkle Tree library for priority queue migration #2035

feat(contracts): Merkle Tree library for priority queue migration

feat(contracts): Merkle Tree library for priority queue migration #2035

Triggered via pull request June 17, 2024 01:34
Status Failure
Total duration 1m 37s
Artifacts

l2-contracts-ci.yaml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

6 errors and 2 warnings
lint: l1-contracts/contracts/common/libraries/openzeppelin/IncrementalMerkle.sol#L99
GC: For [ self ] variable, increment/decrement by 1 using: [ ++variable ] to save gas
lint: l1-contracts/contracts/common/libraries/openzeppelin/IncrementalMerkle.sol#L114
GC: For [ i ] variable, increment/decrement by 1 using: [ ++variable ] to save gas
lint: l1-contracts/contracts/state-transition/chain-deps/DiamondInit.sol#L57
Use double quotes for string literals
lint: l1-contracts/contracts/state-transition/chain-deps/facets/Executor.sol#L343
GC: Found [ .length ] property in Loop condition. Suggestion: assign it to a variable
lint: l1-contracts/contracts/state-transition/libraries/PriorityTree.sol#L62
GC: Use Custom Errors instead of require statements
lint
Process completed with exit code 1.
lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, actions/cache/save@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.