feat(EVM): Cleanup in system contracts #4519
l1-contracts-ci.yaml
on: pull_request
check-verifier-generator
5m 16s
Annotations
13 errors and 6 warnings
lint:
l1-contracts/contracts/state-transition/l2-deps/ISystemContext.sol#L5
imported name AllowedBytecodeTypes is not used
|
lint:
system-contracts/contracts/abstract/SystemContractBase.sol#L6
imported name ACCOUNT_CODE_STORAGE_SYSTEM_CONTRACT is not used
|
lint:
system-contracts/contracts/ContractDeployer.sol#L239
Provide an error message for require
|
lint:
system-contracts/contracts/ContractDeployer.sol#L239
GC: Use Custom Errors instead of require statements
|
lint:
system-contracts/contracts/ContractDeployer.sol#L240
Provide an error message for require
|
lint:
system-contracts/contracts/ContractDeployer.sol#L240
GC: Use Custom Errors instead of require statements
|
lint:
system-contracts/contracts/ContractDeployer.sol#L412
Named parameters missing. MIN unnamed argumenst is 4
|
lint:
system-contracts/contracts/ContractDeployer.sol#L425
Provide an error message for require
|
lint:
system-contracts/contracts/ContractDeployer.sol#L425
GC: Use Custom Errors instead of require statements
|
lint:
system-contracts/contracts/ContractDeployer.sol#L426
Provide an error message for require
|
test-hardhat
Failed to restore cache entry. Exiting as fail-on-cache-miss is set. Input key: artifacts-l1-58acda4010000da79a0ad8a95e71c7c2e70043ce
|
test-foundry
Failed to restore cache entry. Exiting as fail-on-cache-miss is set. Input key: artifacts-l1-58acda4010000da79a0ad8a95e71c7c2e70043ce
|
coverage
Failed to restore cache entry. Exiting as fail-on-cache-miss is set. Input key: artifacts-l1-58acda4010000da79a0ad8a95e71c7c2e70043ce
|
lint:
system-contracts/contracts/ContractDeployer.sol#L182
Avoid to use tx.origin
|
check-verifier-generator
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
check-verifier-generator
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
check-verifier-generator
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
check-verifier-generator
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|